[web] add feedback if user list is empty
ClosedPublic
Actions

Authored by ginsu on Jan 18 2024, 11:03 AM.

Details

Reviewers

ashoat
atul
inka

Commits

rCOMMb90e58e67f76: [web] add feedback if user list is empty

Summary

If the user has typed in something to the search box, but no results are present we should show the user some sort of feedback to make it very clear that there are no results found.

For context, here is what is shown in the figma:

Screenshot 2024-01-18 at 2.05.03 PM.png (1×1 px, 80 KB)

Depends on D10712

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 18 2024, 11:03 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 11:03 AM

Made @ashoat blocking reviewer since this diff has copy

Harbormaster completed remote builds in B25914: Diff 35834.Jan 18 2024, 11:29 AM

ginsu requested review of this revision.Jan 18 2024, 11:29 AM

Unsolicited, but would prefer a simple "No results" without the "Please try searching a different username."

atul added inline comments.Jan 18 2024, 9:48 PM

web/settings/relationship/user-list.react.js
65–71 ↗	(On Diff #35834)	Having this within `userRows` is a little strange because this isn't a user row. Would prefer to have a separate `useMemo` named something like `noResultsMessage` or something and display either that or `userRows` conditionally. Doesn't really make a user-facing difference so feel free to go with whatever you prefer.

Unsolicited, but would prefer a simple "No results" without the "Please try searching a different username."

Agree with this – @ginsu can you adjust before landing, and make sure you put me on all diffs with copy changes in the future? This has come up in the past... please try to remember this time that copy from Ted is not approved and needs to go through me before being landed.

This revision is now accepted and ready to land.Jan 21 2024, 9:56 PM

address feedback copy now just says "No results" + rebase before landing

Harbormaster completed remote builds in B26125: Diff 36096.Jan 24 2024, 12:11 PM

Closed by commit rCOMMb90e58e67f76: [web] add feedback if user list is empty (authored by ginsu). · Explain WhyJan 24 2024, 12:17 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb90e58e67f76: [web] add feedback if user list is empty.