[lib] Pass allKeyserverIDs on in getBoundKeyserverActionFunc
ClosedPublic
Actions

Authored by ashoat on Jan 18 2024, 12:49 PM.

Details

Reviewers

kamil
tomek
inka
atul
ginsu

Commits

rCOMM36b515b9cc74: [lib] Pass allKeyserverIDs on in getBoundKeyserverActionFunc

Summary

This diff resolves ENG-6469. Context on allKeyserverIDs in this code comment.

I accidentally left it out in D10695. This code should have mirrored the non-global version here.

I'm not sure how I missed this during testing. I recall testing web and seeing that it loaded, which was definitely not the case after I tested again after receiving @kamil's report.

Test Plan

I am able to repro the issue before this diff. After this diff, the web app loads normally and I don't see any relevant entries in the console log

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 18 2024, 12:49 PM

Publishing early since it resolves an urgent issue (ENG-6469)

lib/keyserver-conn/call-keyserver-endpoint-provider.react.js
392–395 ↗	(On Diff #35846)	This will get recalculated any time `keyserverCallInfos` changes at all, but that's okay because: `keyserverCallInfos` is optimized to rarely change by using `useDerivedObject` `callKeyserverEndpoint` already depends on `keyserverCallInfos` by way of `getCallSingleKeyserverEndpoint`