Page MenuHomePhabricator
Differential D10723

[lib] Pass allKeyserverIDs on in getBoundKeyserverActionFunc
ClosedPublic
Actions

Authored by ashoat on Jan 18 2024, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 12:18 AM
Unknown Object (File)
Sun, Jun 23, 11:25 PM
Unknown Object (File)
Thu, Jun 20, 12:48 AM
Unknown Object (File)
Fri, Jun 14, 5:11 PM
Unknown Object (File)
Thu, Jun 13, 10:17 PM
Unknown Object (File)
Thu, Jun 13, 10:17 PM
Unknown Object (File)
Tue, Jun 11, 10:09 AM
Unknown Object (File)
Tue, Jun 11, 10:09 AM
View All 24 Files
Subscribers
kamil

Details

Reviewers
kamil
tomek
inka
atul
ginsu
Commits
rCOMM36b515b9cc74: [lib] Pass allKeyserverIDs on in getBoundKeyserverActionFunc
Summary

This diff resolves ENG-6469. Context on allKeyserverIDs in this code comment.

I accidentally left it out in D10695. This code should have mirrored the non-global version here.

I'm not sure how I missed this during testing. I recall testing web and seeing that it loaded, which was definitely not the case after I tested again after receiving @kamil's report.

Test Plan

I am able to repro the issue before this diff. After this diff, the web app loads normally and I don't see any relevant entries in the console log

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 18 2024, 12:49 PM
ashoat published this revision for review.Jan 18 2024, 12:51 PM

Publishing early since it resolves an urgent issue (ENG-6469)

lib/keyserver-conn/call-keyserver-endpoint-provider.react.js
392–395 ↗(On Diff #35846)

This will get recalculated any time keyserverCallInfos changes at all, but that's okay because:

  1. keyserverCallInfos is optimized to rarely change by using useDerivedObject
  2. callKeyserverEndpoint already depends on keyserverCallInfos by way of getCallSingleKeyserverEndpoint
ashoat edited the summary of this revision. (Show Details)Jan 18 2024, 12:51 PM
kamil accepted this revision.Jan 18 2024, 12:57 PM
This revision is now accepted and ready to land.Jan 18 2024, 12:57 PM
Harbormaster completed remote builds in B25925: Diff 35846.Jan 18 2024, 1:08 PM
Closed by commit rCOMM36b515b9cc74: [lib] Pass allKeyserverIDs on in getBoundKeyserverActionFunc (authored by ashoat). · Explain WhyJan 18 2024, 1:09 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM36b515b9cc74: [lib] Pass allKeyserverIDs on in getBoundKeyserverActionFunc.

Revision Contents
Changeset List

PathSize
lib/
keyserver-conn/
10 lines

Diff 35848

View Options

lib/keyserver-conn/call-keyserver-endpoint-provider.react.js

Loading...