[web] fix members modal scrolling behavior
ClosedPublic
Actions

Authored by ginsu on Jan 18 2024, 2:12 PM.

Details

Reviewers

atul
inka

Commits

rCOMMd780c4ef7fca: [web] fix members modal scrolling behavior

Summary

This diff address a bug where the members list was not scrolling with the new refactored tabs I introduced a few weeks ago.

Linear task: https://linear.app/comm/issue/ENG-6470/cant-scroll-members-modal-on-web

Test Plan

Please see the demo video below + also doubled checked with every place that uses the new refactored tabs that they did not have also have any regressions with the scrolling

Diff Detail

Repository

rCOMM Comm

Branch

eng-6470

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 18 2024, 2:12 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 18 2024, 2:12 PM

ginsu edited the summary of this revision. (Show Details)Jan 18 2024, 2:13 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu attached a referenced file: F1072024: Screen Recording 2024-01-18 at 5.08.23 PM.mov. (Show Details)

Harbormaster completed remote builds in B25935: Diff 35857.Jan 18 2024, 2:30 PM

ginsu requested review of this revision.Jan 18 2024, 2:30 PM

inka accepted this revision.Jan 19 2024, 2:06 AM

This revision is now accepted and ready to land.Jan 19 2024, 2:06 AM

Closed by commit rCOMMd780c4ef7fca: [web] fix members modal scrolling behavior (authored by ginsu). · Explain WhyJan 19 2024, 8:10 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMd780c4ef7fca: [web] fix members modal scrolling behavior.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

members-modal.css

6 lines

members-modal.react.js

6 lines

Diff 35857

View Options

web/modals/threads/members/members-modal.css