Call RPC to get keys of all devices of given user.
Depends on D10749
Details
Details
Call method
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- publish-web-outbound
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/identity-service/identity-service-context-provider.react.js | ||
|---|---|---|
| 134 | Is this the right deviceID to use? We probably should use a device id from the result. | |
| native/identity-service/identity-service-context-provider.react.js | ||
|---|---|---|
| 132 | Noticed on line 103 we throw an Error in this case, but it's a little different because we only have one set of keys there, but here are there are multiple. I guess this difference is probably okay | |
| native/identity-service/identity-service-context-provider.react.js | ||
|---|---|---|
| 173–192 ↗ | (On Diff #36210) | not happy with the indentation here but other solutions are not better I think |
| 132 | yeah. that's on purpose to avoid cases when an invalid device's keys in the map cause errors for all | |
| 134 | good call, that was mistake | |
| native/identity-service/identity-service-context-provider.react.js | ||
|---|---|---|
| 173–187 ↗ | (On Diff #36210) | If we're catching what assert throws and replacing it with null, we can simplify it const validatedKeys = deviceOlmOutboundKeysValidator.is(deviceKeys) ? validatedKeys : null; but that would require adding some type annotations |