[lib][native] Merge decryption types into media mission types
ClosedPublic
Actions

Authored by bartek on Jan 28 2024, 7:36 AM.

Details

Reviewers

atul
ashoat

Commits

rCOMM2dd2232e16ee: [lib][native] Merge decryption types into media mission types

Summary

Previously, the "decryption" step/failure types were separated from media mission types.
I need them to be merged in order to be able to add a new "decryption" step in the media mission when saving multimedia.

Simply moved them to media-types.js and updated fuction types accordingly.

Depends on D10852

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 28 2024, 7:36 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJan 28 2024, 7:36 AM

bartek added a child revision: D10854: [native] Add support for saving encrypted media.Jan 28 2024, 7:40 AM

Harbormaster completed remote builds in B26228: Diff 36221.Jan 28 2024, 7:54 AM

bartek published this revision for review.Jan 28 2024, 11:45 PM

Looks like the steps returned by decryptMedia weren't used before. Good thing you implemented it earlier, though – seems like it made work easier for you here!

This revision is now accepted and ready to land.Jan 29 2024, 9:38 AM

In D10853#313118, @ashoat wrote:

Looks like the steps returned by decryptMedia weren't used before. Good thing you implemented it earlier, though – seems like it made work easier for you here!

Yeah! Both encryptMedia() and decryptMedia() had steps implemented, but previously only the former was used in actual "media missions". Decryption was only needed for clients displaying multimedia.