Page MenuHomePhabricator
Differential D10893

[web] Rename `InitialReduxStateResponse` -> `InitialWebReduxStateResponse`
ClosedPublic
Actions

Authored by atul on Jan 31 2024, 10:37 AM.
Tags
None
Referenced Files
F2162574: D10893.diff
Mon, Jul 1, 4:34 PM
Unknown Object (File)
Fri, Jun 21, 3:02 AM
Unknown Object (File)
Sun, Jun 16, 7:27 AM
Unknown Object (File)
Thu, Jun 13, 8:58 AM
Unknown Object (File)
Wed, Jun 12, 3:19 PM
Unknown Object (File)
Apr 8 2024, 3:07 PM
Unknown Object (File)
Feb 21 2024, 4:31 PM
Unknown Object (File)
Feb 21 2024, 12:21 PM
View All 22 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMMfb9cca0fea9f: [web] Rename `InitialReduxStateResponse` -> `InitialWebReduxStateResponse`
Summary

Preparing to move this type to lib by giving it Web* prefix.

Depends on D10892

Test Plan

flow + CI + close reading

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 31 2024, 10:37 AM
atul updated this revision to Diff 36429.Jan 31 2024, 10:40 AM

actually will go with WebInitialReduxStateResponse instead of InitialWebReduxStateResponse for symmetry with the other types even though imo InitialWebReduxStateResponse is a better name in isolation.

atul added a child revision: D10894: [web] Rename `InitialKeyserverInfo` -> `WebInitialKeyserverInfo`.Jan 31 2024, 10:44 AM
Harbormaster completed remote builds in B26356: Diff 36427.Jan 31 2024, 10:54 AM
Harbormaster completed remote builds in B26358: Diff 36429.Jan 31 2024, 10:59 AM
atul requested review of this revision.Jan 31 2024, 10:59 AM
ginsu accepted this revision.Jan 31 2024, 11:02 AM
This revision is now accepted and ready to land.Jan 31 2024, 11:02 AM
Closed by commit rCOMMfb9cca0fea9f: [web] Rename `InitialReduxStateResponse` -> `InitialWebReduxStateResponse` (authored by atul). · Explain WhyJan 31 2024, 12:18 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMfb9cca0fea9f: [web] Rename `InitialReduxStateResponse` -> `InitialWebReduxStateResponse`.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
10 lines
web/
redux/
4 lines
types/
2 lines

Diff 36456

View Options

keyserver/src/responders/redux-state-responders.js

Loading...
View Options

web/redux/action-types.js

Loading...
View Options

web/types/redux-types.js

Loading...