Page MenuHomePhabricator
Differential D10895

[lib] Move `WebInitialReduxStateResponse` to `lib`
ClosedPublic
Actions

Authored by atul on Jan 31 2024, 11:09 AM.
Tags
None
Referenced Files
F2166018: D10895.diff
Tue, Jul 2, 3:07 AM
Unknown Object (File)
Sun, Jun 30, 1:04 AM
Unknown Object (File)
Fri, Jun 21, 3:01 AM
Unknown Object (File)
Apr 8 2024, 3:23 PM
Unknown Object (File)
Apr 8 2024, 3:07 PM
Unknown Object (File)
Mar 12 2024, 1:59 AM
Unknown Object (File)
Mar 10 2024, 5:18 PM
Unknown Object (File)
Mar 2 2024, 8:32 PM
View All 17 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM22572c7a040f: [lib] Move `WebInitialReduxStateResponse` to `lib`
Summary

Move WebInitialReduxStateResponse (and WebInitialKeyserverInfo) to lib.

We will then:

  1. Split into Client and Server variants
  2. Make the client one take ThreadStore and server can take LegacyThreadStore

Depends on D10894

Test Plan

CI + flow + close reading of changes. Used IDE Refactor -> Move tool to make this change.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 31 2024, 11:09 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 31 2024, 11:09 AM
atul added reviewers: ashoat, ginsu, tomek.Jan 31 2024, 11:09 AM
atul added inline comments.Jan 31 2024, 11:13 AM
lib/types/redux-types.js
3–12 ↗(On Diff #36434)

Dang, we have import reordering again, not sure how this is happening.

atul added inline comments.Jan 31 2024, 11:15 AM
lib/types/redux-types.js
3–12 ↗(On Diff #36434)

Guess it wasn't format on save like I thought, IDE automatically sorts these when using the Refactor -> Move tool... will undo changes manually.

atul updated this revision to Diff 36441.Jan 31 2024, 11:27 AM

fix import ordering

Harbormaster completed remote builds in B26362: Diff 36434.Jan 31 2024, 11:28 AM
atul added a child revision: D10898: [lib] Split `WebInitialReduxStateResponse` into `Client/Server` variants.Jan 31 2024, 11:35 AM
atul published this revision for review.Jan 31 2024, 11:36 AM
Harbormaster completed remote builds in B26365: Diff 36441.Jan 31 2024, 11:45 AM
ginsu accepted this revision.Jan 31 2024, 12:20 PM
This revision is now accepted and ready to land.Jan 31 2024, 12:20 PM
Closed by commit rCOMM22572c7a040f: [lib] Move `WebInitialReduxStateResponse` to `lib` (authored by atul). · Explain WhyJan 31 2024, 12:24 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM22572c7a040f: [lib] Move `WebInitialReduxStateResponse` to `lib`.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
6 lines
lib/
types/
22 lines
web/
redux/
6 lines
types/
21 lines

Diff 36459

View Options

keyserver/src/responders/redux-state-responders.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

web/redux/action-types.js

Loading...
View Options

web/types/redux-types.js

Loading...