Page MenuHomePhabricator
Differential D10897

[web] introduce useSortedENSResolvedUsers
ClosedPublic
Actions

Authored by ginsu on Jan 31 2024, 11:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 6:45 PM
Unknown Object (File)
Mon, Jul 1, 9:08 AM
Unknown Object (File)
Sun, Jun 30, 6:00 PM
Unknown Object (File)
Sun, Jun 30, 2:23 PM
Unknown Object (File)
Thu, Jun 27, 2:28 AM
Unknown Object (File)
Thu, Jun 20, 1:58 AM
Unknown Object (File)
Tue, Jun 11, 4:04 PM
Unknown Object (File)
Mar 28 2024, 3:13 PM
View All 28 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM8edec5cb6dad: [web] introduce useSortedENSResolvedUsers
Summary

Got some feedback in D10822 about sorting the users AFTER resolving ENS names. Noticed we needed to make this change in two places in AddUsersList + we will probably want to reuse this logic for the chat members list, so created this hook to factor out the shared logic

Test Plan

Please see the screenshots below

Before:

Screenshot 2024-01-31 at 2.30.29 PM.png (2×3 px, 798 KB)

Screenshot 2024-01-31 at 2.30.41 PM.png (2×3 px, 781 KB)

After:

Screenshot 2024-01-31 at 2.30.58 PM.png (2×3 px, 781 KB)

Screenshot 2024-01-31 at 2.30.48 PM.png (2×3 px, 777 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 31 2024, 11:28 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 31 2024, 11:28 AM
ginsu edited the test plan for this revision. (Show Details)Jan 31 2024, 11:31 AM
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1102600: Screenshot 2024-01-31 at 2.30.48 PM.png. (Show Details)
ginsu attached a referenced file: F1102601: Screenshot 2024-01-31 at 2.30.58 PM.png. (Show Details)
ginsu attached a referenced file: F1102598: Screenshot 2024-01-31 at 2.30.41 PM.png. (Show Details)
ginsu attached a referenced file: F1102599: Screenshot 2024-01-31 at 2.30.29 PM.png. (Show Details)
Harbormaster completed remote builds in B26366: Diff 36442.Jan 31 2024, 11:46 AM
ginsu requested review of this revision.Jan 31 2024, 11:46 AM
atul accepted this revision.Jan 31 2024, 11:48 AM
atul added inline comments.
web/settings/relationship/user-list-hooks.js
14 ↗(On Diff #36442)

nit Resloved -> Resolved

This revision is now accepted and ready to land.Jan 31 2024, 11:48 AM
ginsu updated this revision to Diff 36462.Jan 31 2024, 12:31 PM

address comments

This revision was landed with ongoing or failed builds.Jan 31 2024, 12:36 PM
Closed by commit rCOMM8edec5cb6dad: [web] introduce useSortedENSResolvedUsers (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8edec5cb6dad: [web] introduce useSortedENSResolvedUsers.
Harbormaster completed remote builds in B26373: Diff 36462.Jan 31 2024, 12:50 PM

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
25 lines

Diff 36463

View Options

web/settings/relationship/user-list-hooks.js

Loading...