[web] introduce member list sidebar header
ClosedPublic
Actions

Authored by ginsu on Jan 31 2024, 9:21 PM.

Details

Reviewers

atul
inka
ashoat

Commits

rCOMMdced8049e4c4: [web] introduce member list sidebar header

Summary

This diff introduces the member list sidebar header component.

For context here is what the figma designs for this look like

Screenshot 2024-01-31 at 4.24.05 PM.png (434×992 px, 39 KB)

Linear task: https://linear.app/comm/issue/ENG-5975/introduce-new-member-list-section

Depends on D10899

Test Plan

Please see the demo video below:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 31 2024, 9:21 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 31 2024, 9:21 PM

Making @ashoat blocking since we are introducing new copy

web/chat/member-list-sidebar/member-list-sidebar-header.react.js
37 ↗	(On Diff #36474)	New copy is introduced

Harbormaster completed remote builds in B26379: Diff 36474.Jan 31 2024, 9:40 PM

ginsu requested review of this revision.Jan 31 2024, 9:40 PM

ginsu added a child revision: D10901: [web] introduce threadMembersSelectorForThread.Jan 31 2024, 10:03 PM

Copy looks good! Thanks for adding me

inka accepted this revision.Feb 1 2024, 12:18 PM

This revision is now accepted and ready to land.Feb 1 2024, 12:18 PM

ginsu added a child revision: D10919: [lib] introduce useMembersGroupedByRole.Feb 1 2024, 11:01 PM

ginsu removed a child revision: D10901: [web] introduce threadMembersSelectorForThread.Feb 1 2024, 11:05 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 5 2024, 11:45 PM

Closed by commit rCOMMdced8049e4c4: [web] introduce member list sidebar header. · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMdced8049e4c4: [web] introduce member list sidebar header.

Harbormaster completed remote builds in B26525: Diff 36660.Feb 6 2024, 12:01 AM

ginsu removed a child revision: D10919: [lib] introduce useMembersGroupedByRole.Feb 6 2024, 11:14 PM

Revision Contents
Changeset List

Path

Size

web/

chat/

member-list-sidebar/

member-list-sidebar-header.css

28 lines

member-list-sidebar-header.react.js

52 lines

Diff 36662

View Options

web/chat/member-list-sidebar/member-list-sidebar-header.css