Page MenuHomePhabricator

[lib] Add hook for easy access to CSAT
AbandonedPublic

Authored by bartek on Feb 1 2024, 4:04 AM.
Tags
None
Referenced Files
F2167495: D10909.id36514.diff
Tue, Jul 2, 6:29 AM
F2166509: D10909.diff
Tue, Jul 2, 4:28 AM
Unknown Object (File)
Mon, Jul 1, 8:50 PM
Unknown Object (File)
Fri, Jun 21, 12:50 AM
Unknown Object (File)
Fri, Jun 21, 12:50 AM
Unknown Object (File)
Fri, Jun 21, 12:50 AM
Unknown Object (File)
Wed, Jun 12, 5:10 AM
Unknown Object (File)
May 25 2024, 5:17 AM
Subscribers

Details

Summary

Adds a convenience hook to get CSAT in React components. Ideally, it'd be best to get these from Redux / Context, but getAuthMetadata() is async so I need to use state + effect.
Let me know if there's a better way.

Depends on D10908.

Test Plan

Flow. This is used extensively and tested in the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Feb 1 2024, 4:14 AM
tomek requested changes to this revision.Feb 1 2024, 6:09 AM

This is quite fragile - it should work because in identity context we select commServicesAccessToken, and when it changes, we create a new value of getAuthMetadata function. Also, accessToken and userID are exposed by the same emitter.

Can't we await identityContext?.getAuthMetadata() when we need it?

The proper solution should be to have https://phab.comm.dev/D10867#314643 implemented - but that is currently blocked.

This revision now requires changes to proceed.Feb 1 2024, 6:09 AM
inka requested changes to this revision.Feb 1 2024, 8:29 AM

If you need CSAT, you can just take it from it redux....