Page MenuHomePhabricator

[lib] Bump some endpoint timeouts in `thread-actions`
ClosedPublic

Authored by atul on Feb 1 2024, 10:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 14 2024, 10:19 PM
Unknown Object (File)
Oct 14 2024, 10:19 PM
Unknown Object (File)
Oct 14 2024, 10:19 PM
Unknown Object (File)
Oct 14 2024, 10:18 PM
Unknown Object (File)
Sep 7 2024, 9:56 AM
Unknown Object (File)
Sep 7 2024, 9:24 AM
Unknown Object (File)
Sep 7 2024, 9:24 AM
Unknown Object (File)
Sep 6 2024, 10:33 PM
Subscribers
None

Details

Summary

Based on investigation in https://linear.app/comm/issue/ENG-6136/bump-http-timeouts-for-endpoints-as-needed, the following endpoints needed timeouts bumped:

  • delete_thread
  • remove_members
  • update_thread
  • update_role
Test Plan

Made sure all of the endpoints continued to work as expected.

Trusting the the *EndpointOptions options function as expected and that timeouts will increase. Don't think it's necessary to try to get each of the endpoints to time out and log how long it took the time out. Could add this to Test Plan if deemed necessary.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable