Page MenuHomePhabricator

[lib] Bump some endpoint timeouts in `thread-actions`
ClosedPublic

Authored by atul on Feb 1 2024, 10:53 AM.
Tags
None
Referenced Files
F2188955: D10914.diff
Thu, Jul 4, 9:50 AM
Unknown Object (File)
Wed, Jun 26, 10:52 AM
Unknown Object (File)
Mon, Jun 24, 12:20 AM
Unknown Object (File)
Mon, Jun 24, 12:17 AM
Unknown Object (File)
Sat, Jun 22, 8:47 PM
Unknown Object (File)
Sat, Jun 22, 7:43 AM
Unknown Object (File)
Thu, Jun 20, 12:47 AM
Unknown Object (File)
Wed, Jun 19, 8:28 AM
Subscribers
None

Details

Summary

Based on investigation in https://linear.app/comm/issue/ENG-6136/bump-http-timeouts-for-endpoints-as-needed, the following endpoints needed timeouts bumped:

  • delete_thread
  • remove_members
  • update_thread
  • update_role
Test Plan

Made sure all of the endpoints continued to work as expected.

Trusting the the *EndpointOptions options function as expected and that timeouts will increase. Don't think it's necessary to try to get each of the endpoints to time out and log how long it took the time out. Could add this to Test Plan if deemed necessary.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage