[web] make useSortedENSResolvedUsers more permissive
ClosedPublic
Actions

Authored by ginsu on Feb 1 2024, 3:09 PM.

Details

Reviewers

atul
inka

Commits

rCOMMcf34b97ebde6: [web] make useSortedENSResolvedUsers more permissive

Summary

In the next diff we are going to want to use useSortedENSResolvedUsers to sort + resolve the thread members infos just like we did with the add friend list modal. However, right now useSortedENSResolvedUsers is currently typed so thread members can't use this hook since they use RelativeMemberInfo.

This diff updates useSortedENSResolvedUsers so that it can be used in both places

Test Plan

flow + confirmed that users are sorted correctly in the add users list + thread members list

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 1 2024, 3:09 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 3:09 PM

ginsu edited the summary of this revision. (Show Details)Feb 1 2024, 3:11 PM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10919: [lib] introduce useMembersGroupedByRole.

Harbormaster completed remote builds in B26440: Diff 36558.Feb 1 2024, 3:29 PM

ginsu requested review of this revision.Feb 1 2024, 3:29 PM

ginsu added a child revision: D10921: [web] introduce RoleGroupMemberList.Feb 1 2024, 3:42 PM

atul accepted this revision.Feb 5 2024, 10:53 AM

atul added inline comments.

web/settings/relationship/user-list-hooks.js
8 ↗	(On Diff #36558)	Do we need `isViewer`, or could we just do something like: type BaseUserInfo = { +username?: ?string, ... }; Looks like we only call `useENSNames` and it looks like that only needs `username`