Page MenuHomePhabricator

[web] introduce RoleGroupMemberList
ClosedPublic

Authored by ginsu on Feb 1 2024, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 5:47 PM
Unknown Object (File)
Fri, Nov 8, 10:03 PM
Unknown Object (File)
Fri, Nov 8, 7:15 PM
Unknown Object (File)
Fri, Nov 8, 7:15 PM
Unknown Object (File)
Fri, Nov 8, 7:15 PM
Unknown Object (File)
Fri, Nov 8, 7:15 PM
Unknown Object (File)
Oct 3 2024, 4:51 PM
Unknown Object (File)
Oct 3 2024, 4:50 PM
Subscribers

Details

Summary

This diff introduces the RoleGroupMemberList component. This component handles the logic of sorting + ENS resolving the list of members + will be consumed by the member list sidebar (will be introduced in the next diff)

Linear task: https://linear.app/comm/issue/ENG-5975/introduce-new-member-list-section

Depends on D10919

Test Plan

Please see the screenshot below where the members are sorted in alphabetical order + ens resolved

Screenshot 2024-02-01 at 5.59.33 PM.png (2×3 px, 1003 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu requested review of this revision.Feb 1 2024, 4:09 PM

Makes sense, but can't we ensure that the members are sorted by the time we "get here"?

Would also expect a ListGroup component to have a groupLabel prop as well. Might be worth consolidating the group label into this component if it's currently separate?

This revision is now accepted and ready to land.Feb 5 2024, 10:56 AM
ginsu retitled this revision from [web] introduce SortedMemberListGroup to [web] introduce RoleGroupMemberList.Feb 6 2024, 4:38 PM
ginsu edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Feb 7 2024, 4:42 PM
This revision was automatically updated to reflect the committed changes.