[web] introduce RoleGroupMemberList
ClosedPublic
Actions

Authored by ginsu on Feb 1 2024, 3:40 PM.

Details

Reviewers

atul
inka

Commits

rCOMMe0cb810979e6: [web] introduce RoleGroupMemberList

Summary

This diff introduces the RoleGroupMemberList component. This component handles the logic of sorting + ENS resolving the list of members + will be consumed by the member list sidebar (will be introduced in the next diff)

Linear task: https://linear.app/comm/issue/ENG-5975/introduce-new-member-list-section

Depends on D10919

Test Plan

Please see the screenshot below where the members are sorted in alphabetical order + ens resolved

Screenshot 2024-02-01 at 5.59.33 PM.png (2×3 px, 1003 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 1 2024, 3:40 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 3:40 PM

ginsu edited the summary of this revision. (Show Details)Feb 1 2024, 3:42 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10920: [web] make useSortedENSResolvedUsers more permissive.

ginsu attached a referenced file: F1107114: Screenshot 2024-02-01 at 5.59.33 PM.png. (Show Details)

ginsu added a child revision: D10922: [web] introduce member list sidebar.Feb 1 2024, 3:52 PM

Harbormaster completed remote builds in B26441: Diff 36559.Feb 1 2024, 4:09 PM

ginsu requested review of this revision.Feb 1 2024, 4:09 PM

ashoat mentioned this in D10922: [web] introduce member list sidebar.Feb 2 2024, 7:26 AM

Makes sense, but can't we ensure that the members are sorted by the time we "get here"?

Would also expect a ListGroup component to have a groupLabel prop as well. Might be worth consolidating the group label into this component if it's currently separate?

This revision is now accepted and ready to land.Feb 5 2024, 10:56 AM

ginsu removed a parent revision: D10920: [web] make useSortedENSResolvedUsers more permissive.Feb 6 2024, 3:03 PM

ginsu mentioned this in D10978: [lib/web] lift useSortedENSResolvedUsers into lib.Feb 6 2024, 3:13 PM