[web] update ThreadMember component to match new UI redesign
AcceptedPublic
Actions

Authored by ginsu on Feb 1 2024, 4:46 PM.

Details

Reviewers

atul
inka

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff updates the ThreadMember component so that it matches the new UI redesign. This diff also resolves an issue where long usernames were not properly truncating

For context here is what the thread member component looks like on figma:

Screenshot 2024-02-01 at 7.49.21 PM.png (2×904 px, 278 KB)

Linear task: https://linear.app/comm/issue/ENG-4161/additional-empty-spaces-between-users-on-members-list

Depends on D10922

Test Plan

Please see the screenshot below

Screenshot 2024-02-01 at 7.46.54 PM.png (1×644 px, 71 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Feb 1 2024, 4:46 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 4:46 PM

ginsu edited the summary of this revision. (Show Details)Feb 1 2024, 4:49 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D10922: [web] introduce member list sidebar.

ginsu attached a referenced file: F1107279: Screenshot 2024-02-01 at 7.46.54 PM.png. (Show Details)

ginsu added inline comments.

web/modals/threads/members/member.react.js
106–109	Noticed that we could define this outside the component. Also changed the name to `editIconComponent` because I thought that was a better name for it