Page MenuHomePhabricator
Differential D10988

[native] fix no spacing in the community creation add members screen
ClosedPublic
Actions

Authored by ginsu on Feb 7 2024, 12:10 PM.
Tags
None
Referenced Files
F3509272: D10988.diff
Sat, Dec 21, 3:04 AM
Unknown Object (File)
Oct 31 2024, 5:52 AM
Unknown Object (File)
Oct 31 2024, 5:52 AM
Unknown Object (File)
Oct 31 2024, 5:51 AM
Unknown Object (File)
Oct 31 2024, 5:51 AM
Unknown Object (File)
Oct 31 2024, 5:51 AM
Unknown Object (File)
Oct 3 2024, 1:24 PM
Unknown Object (File)
Sep 19 2024, 12:26 AM
View All 59 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM465dd9109a38: [native] fix no spacing in the community creation add members screen
Summary

The add members section of the community creation add members screen didn't have any spacing. This diff fixes that

Linear task: https://linear.app/comm/issue/ENG-6011/add-minimal-margin-in-the-add-members-screen-in-community-creation

Test Plan

Please see the screenshot below

before:

Screenshot 2024-02-07 at 3.06.51 PM.png (1×944 px, 564 KB)

after:

Screenshot 2024-02-07 at 3.06.39 PM.png (1×1 px, 731 KB)

Screenshot 2024-02-07 at 3.08.30 PM.png (1×1 px, 729 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-6011
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 7 2024, 12:10 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 7 2024, 12:10 PM
ginsu edited the summary of this revision. (Show Details)Feb 7 2024, 12:12 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1126570: Screenshot 2024-02-07 at 3.08.30 PM.png. (Show Details)
ginsu attached a referenced file: F1126569: Screenshot 2024-02-07 at 3.06.39 PM.png. (Show Details)
ginsu attached a referenced file: F1126568: Screenshot 2024-02-07 at 3.06.51 PM.png. (Show Details)
ginsu added inline comments.Feb 7 2024, 12:15 PM
native/community-creation/community-creation-members.react.js
191

I used 20 here so that the tag input/list is aligned with the back button in the header.

The back button in the header has a default left margin of 8px and then we added an additional 12px of left padding in the communityCreationScreenOptions

https://github.com/CommE2E/comm/blob/master/native/community-creation/community-creation-navigator.react.js#L52-L54

Harbormaster completed remote builds in B26628: Diff 36796.Feb 7 2024, 12:28 PM
ginsu requested review of this revision.Feb 7 2024, 12:28 PM
atul accepted this revision.Feb 7 2024, 1:01 PM
This revision is now accepted and ready to land.Feb 7 2024, 1:01 PM
ginsu updated this revision to Diff 36806.Feb 7 2024, 1:49 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 7 2024, 1:50 PM
Closed by commit rCOMM465dd9109a38: [native] fix no spacing in the community creation add members screen (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM465dd9109a38: [native] fix no spacing in the community creation add members screen.
Harbormaster completed remote builds in B26635: Diff 36806.Feb 7 2024, 2:31 PM

Revision Contents
Changeset List

PathSize
native/
community-creation/
32 lines

Diff 36796

View Options

native/community-creation/community-creation-members.react.js

Loading...