Page MenuHomePhabricator
Differential D10989

[native] fix create roles screen bottom of permissions list being cut off
ClosedPublic
Actions

Authored by ginsu on Feb 7 2024, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 7:09 PM
Unknown Object (File)
Thu, Dec 26, 7:09 PM
Unknown Object (File)
Thu, Dec 26, 7:09 PM
Unknown Object (File)
Sun, Dec 15, 11:50 AM
Unknown Object (File)
Nov 8 2024, 10:03 PM
Unknown Object (File)
Nov 8 2024, 10:01 PM
Unknown Object (File)
Nov 8 2024, 7:16 PM
Unknown Object (File)
Nov 8 2024, 7:16 PM
View All 65 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMb1e89a80d2f0: [native] fix create roles screen bottom of permissions list being cut off
Summary

When a user scrolled all the way down on the Permissions list in the Create Role screen, the Manage Invite Links’ description is cut off. This diff adds some padding to the contentContainerStyle of the ScrollView which resolves that visual bug

Linear task: https://linear.app/comm/issue/ENG-6355/permissions-list-in-create-role-screen-is-misaligned

Test Plan

Please see the demo videos below

before:

after:

Diff Detail

Repository
rCOMM Comm
Branch
eng-6355
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 7 2024, 12:42 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 7 2024, 12:42 PM
ginsu edited the summary of this revision. (Show Details)Feb 7 2024, 12:45 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1126795: Screen Recording 2024-02-07 at 3.38.24 PM.mov. (Show Details)
ginsu attached a referenced file: F1126796: Screen Recording 2024-02-07 at 3.38.48 PM.mov. (Show Details)
Harbormaster completed remote builds in B26631: Diff 36801.Feb 7 2024, 12:59 PM
ginsu requested review of this revision.Feb 7 2024, 12:59 PM
atul accepted this revision.Feb 7 2024, 1:03 PM
atul added inline comments.
native/roles/create-roles-screen.react.js
191–223

Could prob memoize since this is native

This revision is now accepted and ready to land.Feb 7 2024, 1:03 PM
ginsu updated this revision to Diff 36812.Feb 7 2024, 2:20 PM

address feedback

This revision was landed with ongoing or failed builds.Feb 7 2024, 2:24 PM
Closed by commit rCOMMb1e89a80d2f0: [native] fix create roles screen bottom of permissions list being cut off (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb1e89a80d2f0: [native] fix create roles screen bottom of permissions list being cut off.
Harbormaster completed remote builds in B26638: Diff 36812.Feb 7 2024, 2:36 PM

Revision Contents
Changeset List

PathSize
native/
roles/
8 lines

Diff 36801

View Options

native/roles/create-roles-screen.react.js

Loading...