Page MenuHomePhabricator

[native] Replace ashoatKeyserverID with authoritativeKeyserverID
ClosedPublic

Authored by inka on Feb 9 2024, 2:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 10:44 PM
Unknown Object (File)
Mon, Oct 28, 12:39 AM
Unknown Object (File)
Mon, Oct 28, 12:39 AM
Unknown Object (File)
Mon, Oct 28, 12:39 AM
Unknown Object (File)
Mon, Oct 28, 12:39 AM
Unknown Object (File)
Mon, Oct 28, 12:39 AM
Unknown Object (File)
Mon, Oct 28, 12:38 AM
Unknown Object (File)
Mon, Oct 28, 12:36 AM
Subscribers

Details

Summary

issue: ENG-6635

Test Plan

Tested that it is possible to send messages, recieve them, create entries, log out, log in, sent media and no errors show up

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 9 2024, 2:24 AM
Harbormaster failed remote builds in B26685: Diff 36899!
inka requested review of this revision.Feb 9 2024, 7:41 AM
This revision is now accepted and ready to land.Feb 12 2024, 1:13 AM

Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID

Rebase - remove changes from Socket, because D11013 replaced ashoatKeyserverID with props.keyserverID

Use value from natvie - we don't need to fetch the value from config on native. We want to use the value fetched from the config, to be able to use it top level

inka requested review of this revision.Feb 20 2024, 4:23 AM
This revision is now accepted and ready to land.Feb 21 2024, 1:32 AM
native/redux/persist.js
938–939 ↗(On Diff #37348)

There will be a lot of issues if a dev has a persisted Redux state and decide to configure an authoritativeKeyserverID. That won't work unless we clear the state - we should mention that in the upcoming doc.

native/redux/persist.js
938–939 ↗(On Diff #37348)

Mentioned this in the doc