Page MenuHomePhabricator
Differential D11028

[terraform] Remove is-dev conditionals for DDB tables
ClosedPublic
Actions

Authored by bartek on Feb 12 2024, 12:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 8:24 AM
Unknown Object (File)
Tue, Mar 25, 4:24 PM
Unknown Object (File)
Wed, Mar 12, 5:04 PM
Unknown Object (File)
Feb 22 2025, 10:03 AM
Unknown Object (File)
Feb 22 2025, 10:03 AM
Unknown Object (File)
Feb 22 2025, 10:03 AM
Unknown Object (File)
Feb 22 2025, 10:03 AM
Unknown Object (File)
Feb 22 2025, 3:40 AM
View All 75 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMMe4c8ec1585a4: [terraform] Remove is-dev conditionals for DDB tables
Summary

Resolves ENG-4545.

  • The identity-users-opaque2 table was dev-only and unused. Introduced in D7241 and removed in D7534
  • The walletAddress-index was never enabled on remote. So wallet login was working on dev only.
Test Plan

Terraform plan for staging and prod.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
terraform/
modules/
shared/
61 lines

Diff 37005

View Options

services/terraform/modules/shared/dynamodb.tf

Show First 20 Lines • Show All 3,330 Lines • ▼ Show 20 Linesvoid SQLiteQueryExecutor::restoreFromMainCompaction(
} }
sqlite3 *backupDB; sqlite3 *backupDB;
if (!is_database_queryable( if (!is_database_queryable(
backupDB, true, mainCompactionPath, mainCompactionEncryptionKey)) { backupDB, true, mainCompactionPath, mainCompactionEncryptionKey)) {
throw std::runtime_error("Backup file or encryption key corrupted."); throw std::runtime_error("Backup file or encryption key corrupted.");
} }
// We don't want to run `PRAGMA key = ...;`
// on main web database. The context is here:
// https://linear.app/comm/issue/ENG-6398/issues-with-sqlcipher-on-web
#ifdef EMSCRIPTEN
kamilAuthorUnsubmitted
Done
Inline Actions

We follow web approach so this comment is not needed anymore

kamil: We follow web approach so this comment is not needed anymore
std::string plaintextBackupPath = mainCompactionPath + "_plaintext"; std::string plaintextBackupPath = mainCompactionPath + "_plaintext";
if (file_exists(plaintextBackupPath)) { if (file_exists(plaintextBackupPath)) {
attempt_delete_file( attempt_delete_file(
plaintextBackupPath, plaintextBackupPath,
"Failed to delete plaintext backup file from previous backup " "Failed to delete plaintext backup file from previous backup "
"attempt."); "attempt.");
} }
sqlite3_open(mainCompactionPath.c_str(), &backupDB);
std::string plaintextMigrationDBQuery = "PRAGMA key = \"x'" + std::string plaintextMigrationDBQuery = "PRAGMA key = \"x'" +
mainCompactionEncryptionKey + mainCompactionEncryptionKey +
"'\";" "'\";"
"ATTACH DATABASE '" + "ATTACH DATABASE '" +
plaintextBackupPath + plaintextBackupPath +
"' AS plaintext KEY '';" "' AS plaintext KEY '';"
"SELECT sqlcipher_export('plaintext');" "SELECT sqlcipher_export('plaintext');"
"DETACH DATABASE plaintext;"; "DETACH DATABASE plaintext;";
executeQuery(backupDB, plaintextMigrationDBQuery);
sqlite3_open(mainCompactionPath.c_str(), &backupDB);
char *plaintextMigrationErr;
sqlite3_exec(
backupDB,
plaintextMigrationDBQuery.c_str(),
nullptr,
nullptr,
&plaintextMigrationErr);
sqlite3_close(backupDB); sqlite3_close(backupDB);
if (plaintextMigrationErr) {
std::stringstream error_message;
error_message << "Failed to migrate backup SQLCipher file to plaintext "
"SQLite file. Details"
<< plaintextMigrationErr << std::endl;
std::string error_message_str = error_message.str();
sqlite3_free(plaintextMigrationErr);
throw std::runtime_error(error_message_str);
}
kamilAuthorUnsubmitted
Done
Inline Actions

executeQuery does exactly the same

kamil: `executeQuery` does exactly the same
sqlite3_open(plaintextBackupPath.c_str(), &backupDB); sqlite3_open(plaintextBackupPath.c_str(), &backupDB);
#else
sqlite3_open(mainCompactionPath.c_str(), &backupDB);
set_encryption_key(backupDB, mainCompactionEncryptionKey);
#endif
int version = this->getSyncedDatabaseVersion(backupDB).value_or(-1); int version = this->getSyncedDatabaseVersion(backupDB).value_or(-1);
if (version > std::stoi(maxVersion)) { if (version > std::stoi(maxVersion)) {
std::stringstream error_message; std::stringstream error_message;
error_message << "Failed to restore a backup because it was created " error_message << "Failed to restore a backup because it was created "
<< "with version " << version << "with version " << version
<< " that is newer than the max supported version " << " that is newer than the max supported version "
<< maxVersion << std::endl; << maxVersion << std::endl;
Show All 20 Lines throw std::runtime_error(
"Programmer error. Database in transaction during restore attempt."); "Programmer error. Database in transaction during restore attempt.");
} else if (backupResult != SQLITE_DONE) { } else if (backupResult != SQLITE_DONE) {
std::stringstream error_message; std::stringstream error_message;
error_message << "Failed to restore database from backup. Details: " error_message << "Failed to restore database from backup. Details: "
<< sqlite3_errstr(backupResult); << sqlite3_errstr(backupResult);
throw std::runtime_error(error_message.str()); throw std::runtime_error(error_message.str());
} }
#ifdef EMSCRIPTEN
attempt_delete_file( attempt_delete_file(
plaintextBackupPath, plaintextBackupPath,
"Failed to delete plaintext compaction file after successful restore."); "Failed to delete plaintext compaction file after successful restore.");
#endif
attempt_delete_file( attempt_delete_file(
mainCompactionPath, mainCompactionPath,
"Failed to delete main compaction file after successful restore."); "Failed to delete main compaction file after successful restore.");
} }
kamilAuthorUnsubmitted
Done
Inline Actions

Previously, there was a bug, for web mainCompactionPath wasn't deleted

kamil: Previously, there was a bug, for web `mainCompactionPath` wasn't deleted
void SQLiteQueryExecutor::restoreFromBackupLog( void SQLiteQueryExecutor::restoreFromBackupLog(
const std::vector<std::uint8_t> &backupLog) const { const std::vector<std::uint8_t> &backupLog) const {
SQLiteQueryExecutor::connectionManager.restoreFromBackupLog(backupLog); SQLiteQueryExecutor::connectionManager.restoreFromBackupLog(backupLog);
} }
} // namespace comm } // namespace comm