Page MenuHomePhabricator
Differential D7534

[identity] register user finish
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 4:01 PM
Unknown Object (File)
Wed, Mar 12, 6:51 AM
Unknown Object (File)
Mar 3 2025, 1:50 AM
Unknown Object (File)
Mar 3 2025, 1:50 AM
Unknown Object (File)
Mar 3 2025, 1:49 AM
Unknown Object (File)
Mar 3 2025, 1:49 AM
Unknown Object (File)
Mar 3 2025, 1:49 AM
Unknown Object (File)
Mar 1 2025, 3:27 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
ashoat
Commits
rCOMM3a8203179c85: [identity] register user finish
Summary

Implement RegisterPasswordUserFinish RPC.

We use the cached state from RegisterPasswordUserStart to complete the
OPAQUE registration workflow, storing a password file for the user and returning
an access token and user ID

Depends on D7533

Test Plan

called the start and finish RPCs, got back a token and id, and verified that the DDB tables were updated. also tried calling the finish RPC >10s after start and got back an error, as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Apr 19 2023, 1:06 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 1:06 PM
varun added a child revision: D7535: [identity] fix numbering issues in proto file.Apr 19 2023, 1:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:19 PM
Harbormaster failed remote builds in B18534: Diff 25398!
varun updated this revision to Diff 25415.Apr 19 2023, 2:19 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:30 PM
Harbormaster failed remote builds in B18550: Diff 25415!
varun updated this revision to Diff 25459.Apr 20 2023, 10:13 AM

rebase

Harbormaster completed remote builds in B18583: Diff 25459.Apr 20 2023, 10:31 AM
varun requested review of this revision.Apr 20 2023, 10:31 AM
• jon accepted this revision.Apr 20 2023, 10:53 AM

Rust looks fine to me

This revision is now accepted and ready to land.Apr 20 2023, 10:53 AM
varun added a reviewer: ashoat.Apr 20 2023, 6:42 PM

there's a .proto change so @ashoat should take a look before I land this

This revision now requires review to proceed.Apr 20 2023, 6:42 PM
ashoat accepted this revision.Apr 21 2023, 6:14 AM
This revision is now accepted and ready to land.Apr 21 2023, 6:14 AM
Closed by commit rCOMM3a8203179c85: [identity] register user finish (authored by varun). · Explain WhyApr 21 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM3a8203179c85: [identity] register user finish.
bartek mentioned this in D11028: [terraform] Remove is-dev conditionals for DDB tables.Feb 12 2024, 12:27 AM
bartek mentioned this in rCOMMe4c8ec1585a4: [terraform] Remove is-dev conditionals for DDB tables.Feb 12 2024, 8:20 AM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
67 lines
111 lines
266 lines
shared/
protos/
2 lines

Diff 25554

View Options

services/identity/src/client_service.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;
View Options

services/identity/src/constants.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;
View Options

services/identity/src/database.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;
View Options

shared/protos/identity_client.proto

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;