Differential D7534

[identity] register user finish
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 1:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 15, 8:56 AM

	Unknown Object (File)
	Thu, Apr 11, 7:58 PM

	Unknown Object (File)
	Thu, Mar 28, 7:41 PM

	Unknown Object (File)
	Thu, Mar 28, 7:41 PM

	Unknown Object (File)
	Thu, Mar 28, 7:41 PM

	Unknown Object (File)
	Thu, Mar 28, 7:41 PM

	Unknown Object (File)
	Thu, Mar 28, 7:40 PM

	Unknown Object (File)
	Thu, Mar 28, 7:38 PM

View All 35 Files

Subscribers

Details

Reviewers

• jon
bartek
ashoat

Commits

rCOMM3a8203179c85: [identity] register user finish

Summary

Implement RegisterPasswordUserFinish RPC.

We use the cached state from RegisterPasswordUserStart to complete the
OPAQUE registration workflow, storing a password file for the user and returning
an access token and user ID

Depends on D7533

Test Plan

called the start and finish RPCs, got back a token and id, and verified that the DDB tables were updated. also tried calling the finish RPC >10s after start and got back an error, as expected

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Apr 19 2023, 1:06 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 1:06 PM

varun added a child revision: D7535: [identity] fix numbering issues in proto file.Apr 19 2023, 1:11 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:19 PM

Harbormaster failed remote builds in B18534: Diff 25398!

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:30 PM

Harbormaster failed remote builds in B18550: Diff 25415!

rebase

Harbormaster completed remote builds in B18583: Diff 25459.Apr 20 2023, 10:31 AM

varun requested review of this revision.Apr 20 2023, 10:31 AM

Rust looks fine to me

This revision is now accepted and ready to land.Apr 20 2023, 10:53 AM

there's a .proto change so @ashoat should take a look before I land this

This revision now requires review to proceed.Apr 20 2023, 6:42 PM

ashoat accepted this revision.Apr 21 2023, 6:14 AM

This revision is now accepted and ready to land.Apr 21 2023, 6:14 AM

Closed by commit rCOMM3a8203179c85: [identity] register user finish (authored by varun). · Explain WhyApr 21 2023, 11:40 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM3a8203179c85: [identity] register user finish.

bartek mentioned this in D11028: [terraform] Remove is-dev conditionals for DDB tables.Feb 12 2024, 12:27 AM

bartek mentioned this in rCOMMe4c8ec1585a4: [terraform] Remove is-dev conditionals for DDB tables.Feb 12 2024, 8:20 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

67 lines

111 lines

266 lines

shared/

protos/

identity_client.proto

2 lines

Diff 25554

services/identity/src/client_service.rs

Loading...

services/identity/src/constants.rs

Loading...

services/identity/src/database.rs

Loading...

shared/protos/identity_client.proto

Loading...