Page MenuHomePhabricator
Differential D7596

[identity] some nits
ClosedPublic
Actions

Authored by varun on Apr 24 2023, 1:51 PM.
Tags
None
Referenced Files
F3527075: D7596.id25644.diff
Tue, Dec 24, 3:31 AM
F3527074: D7596.id25628.diff
Tue, Dec 24, 3:31 AM
F3527067: D7596.id.diff
Tue, Dec 24, 3:31 AM
F3527062: D7596.diff
Tue, Dec 24, 3:29 AM
Unknown Object (File)
Sat, Dec 7, 12:49 AM
Unknown Object (File)
Thu, Dec 5, 1:52 AM
Unknown Object (File)
Thu, Dec 5, 1:45 AM
Unknown Object (File)
Thu, Dec 5, 1:26 AM
View All 74 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMe6f7c4f4af56: [identity] some nits
Summary

small changes to satisfy cargo clippy

Depends on D7595

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Apr 24 2023, 1:51 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 24 2023, 1:51 PM
Harbormaster completed remote builds in B18715: Diff 25628.Apr 24 2023, 2:21 PM
varun requested review of this revision.Apr 24 2023, 2:21 PM
• jon accepted this revision.Apr 24 2023, 3:23 PM
• jon added inline comments.
services/identity/src/config.rs
100 ↗(On Diff #25628)

If we can borrow here, I think we should. Guess it doesn't really matter

This revision is now accepted and ready to land.Apr 24 2023, 3:23 PM
varun added inline comments.Apr 24 2023, 8:32 PM
services/identity/src/config.rs
100 ↗(On Diff #25628)

contents is already a &str so the borrow is redundant, which clippy doesn't like

bartek accepted this revision.Apr 24 2023, 8:34 PM
Closed by commit rCOMMe6f7c4f4af56: [identity] some nits (authored by varun). · Explain WhyApr 24 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe6f7c4f4af56: [identity] some nits.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
6 lines

Diff 25644

View Options

services/identity/src/config.rs

Loading...