Page MenuHomePhabricator

[identity] verify user access token
ClosedPublic

Authored by varun on Apr 24 2023, 1:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 8, 2:54 PM
Unknown Object (File)
Sun, May 7, 8:25 PM
Unknown Object (File)
Sun, May 7, 1:00 PM
Unknown Object (File)
Tue, May 2, 11:09 PM
Unknown Object (File)
Apr 25 2023, 5:52 AM
Subscribers

Details

Summary

basically copied the old RPC implementation

Depends on D7553

Test Plan

called the RPC with bloomRPC with an existing valid token, existing invalid token, and nonexistent token

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Apr 24 2023, 2:07 PM
jon added inline comments.
services/identity/src/client_service.rs
638 ↗(On Diff #25625)

I know this was named to fit the protobuf message format, but generally I feel that boolean values should be named something to indicate it is a boolean value, such as isXXX or hasXXX.

With token_valid, I'm not sure if this is "contents of a valid token" or "if the token is valid"

This revision is now accepted and ready to land.Apr 24 2023, 3:21 PM
This revision was automatically updated to reflect the committed changes.