basically copied the old RPC implementation
Depends on D7553
Details
Details
- Reviewers
• jon bartek - Commits
- rCOMMba611145c1a4: [identity] verify user access token
called the RPC with bloomRPC with an existing valid token, existing invalid token, and nonexistent token
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/identity/src/client_service.rs | ||
|---|---|---|
| 638 ↗ | (On Diff #25625) | I know this was named to fit the protobuf message format, but generally I feel that boolean values should be named something to indicate it is a boolean value, such as isXXX or hasXXX. With token_valid, I'm not sure if this is "contents of a valid token" or "if the token is valid" |