Page MenuHomePhabricator

[identity] update user password
ClosedPublic

Authored by varun on Apr 20 2023, 11:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:09 PM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 7:08 PM
Unknown Object (File)
Sun, Dec 15, 7:02 PM
Unknown Object (File)
Nov 26 2024, 5:43 PM
Unknown Object (File)
Oct 27 2024, 12:19 AM
Unknown Object (File)
Oct 1 2024, 1:02 PM
Unknown Object (File)
Oct 1 2024, 1:02 PM
Subscribers

Details

Summary

updated_user_password start and finish methods. also added a DB method
to update the users table.

changed the .proto because we needed some more info to retrieve an access token, and we don't actually need to mint a new token after successful password update.

Depends on D7544

Test Plan

registered a new user with a password. then called the update password RPCs, and was able to successfully log in with my new password. the old password no longer worked, and returned an error.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shared/protos/identity_client.proto
150–153 ↗(On Diff #25468)

Same question as here:

Can you clarify why these are being added? Is it impossible to look up an accessToken just by itself, and we always need to include userID and deviceIDKey in order to validate it? (Guessing this is the case based on VerifyUserAccessTokenRequest)

shared/protos/identity_client.proto
150–153 ↗(On Diff #25468)

yeah in our access token table, the primary key is user ID + device ID (ed25519 signing key)

Thanks!! Proto change makes sense to me; resigning so others can take a look at the Rust

This revision is now accepted and ready to land.Apr 24 2023, 12:42 PM
This revision was automatically updated to reflect the committed changes.