[identity] update user password
ClosedPublic
Actions

Authored by varun on Apr 20 2023, 11:36 AM.

Details

Reviewers

• jon
bartek
ashoat

Commits

rCOMM3bf41977063b: [identity] update user password

Summary

updated_user_password start and finish methods. also added a DB method
to update the users table.

changed the .proto because we needed some more info to retrieve an access token, and we don't actually need to mint a new token after successful password update.

Depends on D7544

Test Plan

registered a new user with a password. then called the update password RPCs, and was able to successfully log in with my new password. the old password no longer worked, and returned an error.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Apr 20 2023, 11:36 AM

Herald added subscribers: atul, tomek. · View Herald TranscriptApr 20 2023, 11:36 AM

Harbormaster completed remote builds in B18592: Diff 25468.Apr 20 2023, 11:54 AM

varun requested review of this revision.Apr 20 2023, 11:54 AM

ashoat added inline comments.Apr 21 2023, 6:06 AM

shared/protos/identity_client.proto
150–153 ↗	(On Diff #25468)	Same question as here: Can you clarify why these are being added? Is it impossible to look up an `accessToken` just by itself, and we always need to include `userID` and `deviceIDKey` in order to validate it? (Guessing this is the case based on `VerifyUserAccessTokenRequest`)