Details

Reviewers

• jon
bartek

Commits

rCOMMee0fde6c2817: [identity] register start

Summary

implement the RegisterPasswordUserStart RPC

If this RPC is successful, we cache the state for 10 seconds while we wait
for the

Depends on D7532

Test Plan

tested with RegisterPasswordUserFinish RPC in subsequent diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Apr 19 2023, 12:56 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 12:56 PM

varun added a child revision: D7534: [identity] register user finish.Apr 19 2023, 1:06 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:09 PM

Harbormaster failed remote builds in B18533: Diff 25397!

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:51 PM

Harbormaster failed remote builds in B18544: Diff 25408!

fix CI

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:29 PM

Harbormaster failed remote builds in B18549: Diff 25414!

forgot to check in Cargo.lock files

Harbormaster completed remote builds in B18559: Diff 25424.Apr 19 2023, 2:57 PM

varun requested review of this revision.Apr 19 2023, 2:57 PM

• jon requested changes to this revision.Apr 20 2023, 10:49 AM

• jon added inline comments.

services/identity/src/client_service.rs
42 ↗	(On Diff #25424)	This is really similar to OPAQUE's usage of registration structs, but means something else. Can we rename this to something like `UserDeviceInfo` or `UserRegistrationInfo`

This revision now requires changes to proceed.Apr 20 2023, 10:49 AM

address feedback

Harbormaster completed remote builds in B18596: Diff 25473.Apr 20 2023, 2:48 PM

• jon accepted this revision.Apr 20 2023, 2:54 PM

This revision is now accepted and ready to land.Apr 20 2023, 2:54 PM

Closed by commit rCOMMee0fde6c2817: [identity] register start (authored by varun). · Explain WhyApr 21 2023, 11:40 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMee0fde6c2817: [identity] register start.

[identity] register start
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25555

keyserver/addons/rust-node-addon/Cargo.lock

keyserver/addons/rust-node-addon/Cargo.toml

native/native_rust_library/Cargo.lock

native/native_rust_library/Cargo.toml

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/src/client_service.rs

services/identity/src/database.rs

services/identity/src/id.rs

services/identity/src/main.rs

shared/comm-opaque2/Cargo.lock

shared/comm-opaque2/Cargo.toml

[identity] register startClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25555

keyserver/addons/rust-node-addon/Cargo.lock

keyserver/addons/rust-node-addon/Cargo.toml

native/native_rust_library/Cargo.lock

native/native_rust_library/Cargo.toml

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/src/client_service.rs

services/identity/src/database.rs

services/identity/src/id.rs

services/identity/src/main.rs

shared/comm-opaque2/Cargo.lock

shared/comm-opaque2/Cargo.toml

[identity] register start
ClosedPublic
Actions

Revision Contents
Changeset List