Page MenuHomePhabricator
Differential D7533

[identity] register start
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 1:34 PM
Unknown Object (File)
Sat, Feb 22, 10:02 AM
Unknown Object (File)
Feb 17 2025, 3:30 PM
Unknown Object (File)
Feb 15 2025, 10:31 PM
Unknown Object (File)
Feb 1 2025, 1:33 AM
Unknown Object (File)
Jan 31 2025, 6:14 AM
Unknown Object (File)
Jan 31 2025, 6:14 AM
Unknown Object (File)
Jan 31 2025, 6:14 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMee0fde6c2817: [identity] register start
Summary

implement the RegisterPasswordUserStart RPC

If this RPC is successful, we cache the state for 10 seconds while we wait
for the

Depends on D7532

Test Plan

tested with RegisterPasswordUserFinish RPC in subsequent diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Apr 19 2023, 12:56 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 12:56 PM
varun added a child revision: D7534: [identity] register user finish.Apr 19 2023, 1:06 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:09 PM
Harbormaster failed remote builds in B18533: Diff 25397!
varun updated this revision to Diff 25408.Apr 19 2023, 1:38 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:51 PM
Harbormaster failed remote builds in B18544: Diff 25408!
varun updated this revision to Diff 25414.Apr 19 2023, 2:17 PM

fix CI

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:29 PM
Harbormaster failed remote builds in B18549: Diff 25414!
varun updated this revision to Diff 25424.Apr 19 2023, 2:41 PM

forgot to check in Cargo.lock files

Harbormaster completed remote builds in B18559: Diff 25424.Apr 19 2023, 2:57 PM
varun requested review of this revision.Apr 19 2023, 2:57 PM
• jon requested changes to this revision.Apr 20 2023, 10:49 AM
• jon added inline comments.
services/identity/src/client_service.rs
42 ↗(On Diff #25424)

This is really similar to OPAQUE's usage of registration structs, but means something else. Can we rename this to something like UserDeviceInfo or UserRegistrationInfo

This revision now requires changes to proceed.Apr 20 2023, 10:49 AM
varun updated this revision to Diff 25473.Apr 20 2023, 2:29 PM

address feedback

Harbormaster completed remote builds in B18596: Diff 25473.Apr 20 2023, 2:48 PM
• jon accepted this revision.Apr 20 2023, 2:54 PM
This revision is now accepted and ready to land.Apr 20 2023, 2:54 PM
Closed by commit rCOMMee0fde6c2817: [identity] register start (authored by varun). · Explain WhyApr 21 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMee0fde6c2817: [identity] register start.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
4 lines
native/
native_rust_library/
4 lines
services/
identity/
2 lines
src/
106 lines
11 lines
18 lines
12 lines
shared/
comm-opaque2/
2 lines

Diff 25555

View Options

keyserver/addons/rust-node-addon/Cargo.lock

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines () =>
tab: 'chat', tab: 'chat',
}; };
dispatch({ type: updateNavInfoActionType, payload }); dispatch({ type: updateNavInfoActionType, payload });
}, },
), ),
[dispatch], [dispatch],
); );
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (prevLocalToken.current && !localToken) {
electron?.fetchDeviceToken?.();
}
prevLocalToken.current = localToken;
}, [localToken]);
} }
function useCreatePushSubscription(): () => Promise<void> { function useCreatePushSubscription(): () => Promise<void> {
const publicKey = useSelector(state => state.pushApiPublicKey); const publicKey = useSelector(state => state.pushApiPublicKey);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callSetDeviceToken = useSetDeviceTokenFanout(); const callSetDeviceToken = useSetDeviceTokenFanout();
const staffCanSee = useStaffCanSee(); const staffCanSee = useStaffCanSee();
▲ Show 20 Lines • Show All 136 Lines • ▼ Show 20 Lines const callback = (event: MessageEvent) => {
} }
}; };
navigator.serviceWorker.addEventListener('message', callback); navigator.serviceWorker.addEventListener('message', callback);
return () => return () =>
navigator.serviceWorker?.removeEventListener('message', callback); navigator.serviceWorker?.removeEventListener('message', callback);
}, [dispatch, supported]); }, [dispatch, supported]);
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (
!navigator.serviceWorker ||
!supported ||
Notification.permission !== 'granted'
) {
return;
}
if (prevLocalToken.current && !localToken) {
void createPushSubscription();
}
prevLocalToken.current = localToken;
}, [createPushSubscription, localToken, supported]);
return null; return null;
} }
export { PushNotificationsHandler, useCreatePushSubscription }; export { PushNotificationsHandler, useCreatePushSubscription };
View Options

keyserver/addons/rust-node-addon/Cargo.toml

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines () =>
tab: 'chat', tab: 'chat',
}; };
dispatch({ type: updateNavInfoActionType, payload }); dispatch({ type: updateNavInfoActionType, payload });
}, },
), ),
[dispatch], [dispatch],
); );
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (prevLocalToken.current && !localToken) {
electron?.fetchDeviceToken?.();
}
prevLocalToken.current = localToken;
}, [localToken]);
} }
function useCreatePushSubscription(): () => Promise<void> { function useCreatePushSubscription(): () => Promise<void> {
const publicKey = useSelector(state => state.pushApiPublicKey); const publicKey = useSelector(state => state.pushApiPublicKey);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callSetDeviceToken = useSetDeviceTokenFanout(); const callSetDeviceToken = useSetDeviceTokenFanout();
const staffCanSee = useStaffCanSee(); const staffCanSee = useStaffCanSee();
▲ Show 20 Lines • Show All 136 Lines • ▼ Show 20 Lines const callback = (event: MessageEvent) => {
} }
}; };
navigator.serviceWorker.addEventListener('message', callback); navigator.serviceWorker.addEventListener('message', callback);
return () => return () =>
navigator.serviceWorker?.removeEventListener('message', callback); navigator.serviceWorker?.removeEventListener('message', callback);
}, [dispatch, supported]); }, [dispatch, supported]);
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (
!navigator.serviceWorker ||
!supported ||
Notification.permission !== 'granted'
) {
return;
}
if (prevLocalToken.current && !localToken) {
void createPushSubscription();
}
prevLocalToken.current = localToken;
}, [createPushSubscription, localToken, supported]);
return null; return null;
} }
export { PushNotificationsHandler, useCreatePushSubscription }; export { PushNotificationsHandler, useCreatePushSubscription };
View Options

native/native_rust_library/Cargo.lock

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines () =>
tab: 'chat', tab: 'chat',
}; };
dispatch({ type: updateNavInfoActionType, payload }); dispatch({ type: updateNavInfoActionType, payload });
}, },
), ),
[dispatch], [dispatch],
); );
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (prevLocalToken.current && !localToken) {
electron?.fetchDeviceToken?.();
}
prevLocalToken.current = localToken;
}, [localToken]);
} }
function useCreatePushSubscription(): () => Promise<void> { function useCreatePushSubscription(): () => Promise<void> {
const publicKey = useSelector(state => state.pushApiPublicKey); const publicKey = useSelector(state => state.pushApiPublicKey);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callSetDeviceToken = useSetDeviceTokenFanout(); const callSetDeviceToken = useSetDeviceTokenFanout();
const staffCanSee = useStaffCanSee(); const staffCanSee = useStaffCanSee();
▲ Show 20 Lines • Show All 136 Lines • ▼ Show 20 Lines const callback = (event: MessageEvent) => {
} }
}; };
navigator.serviceWorker.addEventListener('message', callback); navigator.serviceWorker.addEventListener('message', callback);
return () => return () =>
navigator.serviceWorker?.removeEventListener('message', callback); navigator.serviceWorker?.removeEventListener('message', callback);
}, [dispatch, supported]); }, [dispatch, supported]);
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (
!navigator.serviceWorker ||
!supported ||
Notification.permission !== 'granted'
) {
return;
}
if (prevLocalToken.current && !localToken) {
void createPushSubscription();
}
prevLocalToken.current = localToken;
}, [createPushSubscription, localToken, supported]);
return null; return null;
} }
export { PushNotificationsHandler, useCreatePushSubscription }; export { PushNotificationsHandler, useCreatePushSubscription };
View Options

native/native_rust_library/Cargo.toml

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines () =>
tab: 'chat', tab: 'chat',
}; };
dispatch({ type: updateNavInfoActionType, payload }); dispatch({ type: updateNavInfoActionType, payload });
}, },
), ),
[dispatch], [dispatch],
); );
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (prevLocalToken.current && !localToken) {
electron?.fetchDeviceToken?.();
}
prevLocalToken.current = localToken;
}, [localToken]);
} }
function useCreatePushSubscription(): () => Promise<void> { function useCreatePushSubscription(): () => Promise<void> {
const publicKey = useSelector(state => state.pushApiPublicKey); const publicKey = useSelector(state => state.pushApiPublicKey);
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callSetDeviceToken = useSetDeviceTokenFanout(); const callSetDeviceToken = useSetDeviceTokenFanout();
const staffCanSee = useStaffCanSee(); const staffCanSee = useStaffCanSee();
▲ Show 20 Lines • Show All 136 Lines • ▼ Show 20 Lines const callback = (event: MessageEvent) => {
} }
}; };
navigator.serviceWorker.addEventListener('message', callback); navigator.serviceWorker.addEventListener('message', callback);
return () => return () =>
navigator.serviceWorker?.removeEventListener('message', callback); navigator.serviceWorker?.removeEventListener('message', callback);
}, [dispatch, supported]); }, [dispatch, supported]);
// Handle invalid device token
const localToken = useSelector(
state => state.tunnelbrokerDeviceToken.localToken,
);
const prevLocalToken = React.useRef(localToken);
React.useEffect(() => {
if (
!navigator.serviceWorker ||
!supported ||
Notification.permission !== 'granted'
) {
return;
}
if (prevLocalToken.current && !localToken) {
void createPushSubscription();
}
prevLocalToken.current = localToken;
}, [createPushSubscription, localToken, supported]);
return null; return null;
} }
export { PushNotificationsHandler, useCreatePushSubscription }; export { PushNotificationsHandler, useCreatePushSubscription };
View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/id.rs

Loading...
View Options

services/identity/src/main.rs

Loading...
View Options

shared/comm-opaque2/Cargo.lock

Loading...
View Options

shared/comm-opaque2/Cargo.toml

Loading...