[identity] use ed25519 key instead of curve as map key
ClosedPublic
Actions

Authored by varun on Apr 24 2023, 1:50 PM.

Details

Reviewers

• jon
bartek

Commits

rCOMM797613b5131e: [identity] use ed25519 key instead of curve as map key

Summary

we should be using the ed25519 key as the map key in DDB to be consistent with comments in the .proto file and constants.rs. this was an oversight on my part

Test Plan

checked that the DDB table map was now keyed on the correct signing public key

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Apr 24 2023, 1:50 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 24 2023, 1:50 PM

varun added a child revision: D7596: [identity] some nits.Apr 24 2023, 1:51 PM

varun added a parent revision: D7594: [identity] verify user access token.Apr 24 2023, 1:51 PM

Harbormaster completed remote builds in B18713: Diff 25626.Apr 24 2023, 2:09 PM

varun requested review of this revision.Apr 24 2023, 2:09 PM

• jon accepted this revision.Apr 24 2023, 3:22 PM

This revision is now accepted and ready to land.Apr 24 2023, 3:22 PM

Closed by commit rCOMM797613b5131e: [identity] use ed25519 key instead of curve as map key (authored by varun). · Explain WhyApr 24 2023, 8:34 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM797613b5131e: [identity] use ed25519 key instead of curve as map key.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

6 lines

Diff 25643

View Options

services/identity/src/client_service.rs

	Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
	class RemoveAllMessagesOperation : public MessageStoreOperationBase {			class RemoveAllMessagesOperation : public MessageStoreOperationBase {
	public:			public:
	virtual void execute() override {			virtual void execute() override {
	DatabaseManager::getQueryExecutor().removeAllMessages();			DatabaseManager::getQueryExecutor().removeAllMessages();
	DatabaseManager::getQueryExecutor().removeAllMedia();			DatabaseManager::getQueryExecutor().removeAllMedia();
	}			}
	};			};

				class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
				public:
				ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
				: msg_threads{} {
				auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
				for (size_t idx = 0; idx < threads.size(rt); idx++) {
				auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);

				auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
				auto start_reached = std::stoi(
				thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
				auto last_navigated_to = std::stoll(
				thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
				auto last_pruned = std::stoll(
				thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));

				MessageStoreThread msg_thread = MessageStoreThread{
				thread_id, start_reached, last_navigated_to, last_pruned};
				this->msg_threads.push_back(msg_thread);
				}
				}

				virtual void execute() override {
				DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
				this->msg_threads);
				}

				private:
				std::vector<MessageStoreThread> msg_threads;
				};

				class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
				public:
				virtual void execute() override {
				DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
				}
				};

				class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
				public:
				RemoveMessageStoreThreadsOperation(
				jsi::Runtime &rt,
				const jsi::Object &payload)
				: thread_ids{} {
				auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
				for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
				this->thread_ids.push_back(
				payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
				}
				}

				virtual void execute() override {
				DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
				this->thread_ids);
				}

				private:
				std::vector<std::string> thread_ids;
				};

	} // namespace comm			} // namespace comm

[identity] use ed25519 key instead of curve as map keyClosedPublicActions