Paths

Table of Contentst

Differential D7544

[identity] delete user RPC
ClosedPublic
Actions

Authored by varun on Apr 19 2023, 2:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 28, 7:41 PM

	Unknown Object (File)
	Thu, Mar 28, 7:38 PM

	Unknown Object (File)
	Mar 12 2024, 7:21 PM

	Unknown Object (File)
	Mar 12 2024, 7:15 PM

	Unknown Object (File)
	Mar 7 2024, 7:03 AM

	Unknown Object (File)
	Mar 7 2024, 5:56 AM

	Unknown Object (File)
	Mar 7 2024, 5:22 AM

	Unknown Object (File)
	Mar 7 2024, 5:21 AM

View All 31 Files

Subscribers

Details

Reviewers

• jon
bartek

Commits

rCOMMeed2eaeb3422: [identity] delete user RPC

Summary

Depends on D7541

Test Plan

registered a new user, then successfully deleted it

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Apr 19 2023, 2:13 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 19 2023, 2:14 PM

rebase

Harbormaster failed remote builds in B18548: Diff 25413!Apr 19 2023, 2:26 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:39 PM

Harbormaster failed remote builds in B18558: Diff 25423!

rebase

Harbormaster completed remote builds in B18591: Diff 25467.Apr 20 2023, 10:43 AM

varun requested review of this revision.Apr 20 2023, 10:43 AM

varun added a child revision: D7553: [identity] update user password.Apr 20 2023, 11:36 AM

ashoat added inline comments.Apr 21 2023, 6:03 AM

shared/protos/identity_client.proto
222–225 ↗	(On Diff #25467)	Can you clarify why these are being added? Is it impossible to look up an `accessToken` just by itself, and we always need to include `userID` and `deviceIDKey` in order to validate it? (Guessing this is the case based on `VerifyUserAccessTokenRequest`)

varun added inline comments.Apr 21 2023, 11:26 AM

shared/protos/identity_client.proto
222–225 ↗	(On Diff #25467)	yeah in our access token table, the primary key is user ID + device ID (ed25519 signing key)

ashoat added inline comments.Apr 21 2023, 11:58 AM

shared/protos/identity_client.proto
222–225 ↗	(On Diff #25467)	Thanks!

• jon accepted this revision.Apr 24 2023, 1:08 PM

This revision is now accepted and ready to land.Apr 24 2023, 1:08 PM

Closed by commit rCOMMeed2eaeb3422: [identity] delete user RPC (authored by varun). · Explain WhyApr 24 2023, 8:34 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMeed2eaeb3422: [identity] delete user RPC.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

28 lines

4 lines

shared/

protos/

identity_client.proto

4 lines

Diff 25640

services/identity/src/client_service.rs

Loading...

services/identity/src/token.rs

Loading...

shared/protos/identity_client.proto

Loading...