Page MenuHomePhabricator

[identity] delete user RPC
ClosedPublic

Authored by varun on Apr 19 2023, 2:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 6, 8:26 AM
Unknown Object (File)
Thu, May 4, 12:35 AM
Unknown Object (File)
Wed, May 3, 10:16 PM
Unknown Object (File)
Wed, May 3, 6:42 AM
Unknown Object (File)
May 1 2023, 10:00 PM
Unknown Object (File)
Apr 28 2023, 3:18 AM
Unknown Object (File)
Apr 24 2023, 9:00 PM
Unknown Object (File)
Apr 24 2023, 8:56 PM
Subscribers

Details

Summary

Depends on D7541

Test Plan

registered a new user, then successfully deleted it

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:39 PM
Harbormaster failed remote builds in B18558: Diff 25423!
shared/protos/identity_client.proto
222–225 ↗(On Diff #25467)

Can you clarify why these are being added? Is it impossible to look up an accessToken just by itself, and we always need to include userID and deviceIDKey in order to validate it? (Guessing this is the case based on VerifyUserAccessTokenRequest)

shared/protos/identity_client.proto
222–225 ↗(On Diff #25467)

yeah in our access token table, the primary key is user ID + device ID (ed25519 signing key)

shared/protos/identity_client.proto
222–225 ↗(On Diff #25467)

Thanks!

This revision is now accepted and ready to land.Apr 24 2023, 1:08 PM
This revision was automatically updated to reflect the committed changes.