Page MenuHomePhabricator

[identity] manage login state
ClosedPublic

Authored by varun on Apr 19 2023, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:36 AM
Unknown Object (File)
Sun, Oct 27, 2:34 AM
Unknown Object (File)
Fri, Oct 11, 9:26 PM
Unknown Object (File)
Sun, Oct 6, 10:56 PM
Subscribers

Details

Summary

Updated the cache to handle both registration and login state

Depends on D7535

Test Plan

tested later with OPAQUE login workflow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 1:26 PM
Harbormaster failed remote builds in B18536: Diff 25400!
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2023, 2:31 PM
Harbormaster failed remote builds in B18552: Diff 25417!
jon added inline comments.
services/identity/src/client_service.rs
40–50 ↗(On Diff #25461)

Remove the middle-man?

This revision now requires changes to proceed.Apr 20 2023, 10:55 AM

Nevermind, the struct is used to also hold the login state later on.

This revision is now accepted and ready to land.Apr 20 2023, 10:58 AM
bartek added inline comments.
services/identity/src/client_service.rs
40–50 ↗(On Diff #25461)

I think the "middle-man" makes the code more "structured" and extensible in the future

This revision was automatically updated to reflect the committed changes.