Page MenuHomePhabricator

[native] persist OLM account on SQLiteQueryExecutor::storeOlmPersistData
ClosedPublic

Authored by varun on Feb 14 2024, 6:53 PM.
Tags
None
Referenced Files
F3505150: D11086.diff
Fri, Dec 20, 12:29 PM
Unknown Object (File)
Nov 16 2024, 5:54 PM
Unknown Object (File)
Nov 16 2024, 5:54 PM
Unknown Object (File)
Nov 16 2024, 5:54 PM
Unknown Object (File)
Nov 16 2024, 5:54 PM
Unknown Object (File)
Oct 14 2024, 9:57 PM
Unknown Object (File)
Oct 14 2024, 9:57 PM
Unknown Object (File)
Oct 14 2024, 9:57 PM
Subscribers

Details

Summary

It looks like when we refactored storeOlmPersistData as part of removing sqlite_orm, we accidentally stopped persisting the OLM account. As a result, CommCoreModule::initializeCryptoAccount() was creating a new OLM account each time it was called. This one line change fixed things.

Test Plan

called initializeCryptoAccount() multiple times and confirmed it was idempotent (returned the same identity keys) after this fix

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage