Page MenuHomePhabricator
Differential D11088

[keyserver] Log the exception when failing to synchronize links with blobs
ClosedPublic
Actions

Authored by tomek on Feb 15 2024, 2:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 3:18 PM
Unknown Object (File)
Thu, Apr 17, 11:57 AM
Unknown Object (File)
Thu, Apr 17, 1:07 AM
Unknown Object (File)
Wed, Apr 16, 1:26 PM
Unknown Object (File)
Tue, Apr 15, 6:42 AM
Unknown Object (File)
Sat, Mar 29, 12:10 AM
Unknown Object (File)
Fri, Mar 28, 9:11 PM
Unknown Object (File)
Feb 16 2025, 12:08 PM
View All 56 Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
inka
Commits
rCOMMe3478a83cfbb: [keyserver] Log the exception when failing to synchronize links with blobs
Summary

This will help with debugging potential issues.

Test Plan

Kill the keyserver, delete auth metadata, decrement db version, delete the holder and update invite link secret. Then run the keyserver - the migration should succeed by printing an error message and an exception about invalid_credentials.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Feb 15 2024, 2:33 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 15 2024, 2:33 AM
Harbormaster completed remote builds in B26907: Diff 37228.Feb 15 2024, 2:47 AM
tomek requested review of this revision.Feb 15 2024, 2:47 AM
inka accepted this revision.Feb 15 2024, 3:15 AM
This revision is now accepted and ready to land.Feb 15 2024, 3:15 AM
Closed by commit rCOMMe3478a83cfbb: [keyserver] Log the exception when failing to synchronize links with blobs (authored by tomek). · Explain WhyFeb 15 2024, 3:22 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMe3478a83cfbb: [keyserver] Log the exception when failing to synchronize links with blobs.
ashoat added a comment.Feb 15 2024, 7:25 AM

The synchronizeInviteLinksWithBlobs.js filename does not follow conventions in our codebase. We should maintain consistent file naming conventions. @tomek, can you do an audit of the invite links code to make sure we match file naming conventions with the rest of the codebase? Would be great if you could create a task to track

tomek added a comment.EditedFeb 15 2024, 7:51 AM
In D11088#320294, @ashoat wrote:

The synchronizeInviteLinksWithBlobs.js filename does not follow conventions in our codebase. We should maintain consistent file naming conventions. @tomek, can you do an audit of the invite links code to make sure we match file naming conventions with the rest of the codebase? Would be great if you could create a task to track

Sorry for that! Created a task tracking it https://linear.app/comm/issue/ENG-6819/make-sure-js-file-names-are-consistent - will prioritize it, as it should be a quick one.

Revision Contents
Changeset List

PathSize
keyserver/
src/
utils/
2 lines

Diff 37229

View Options

keyserver/src/utils/synchronizeInviteLinksWithBlobs.js

Loading...