This differential enables SQLite database to hold to olm accounts: content and notifs.
Details
Details
Run olm tables tests from database/queries directory.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 18–19 ↗ | (On Diff #37375) | Could we define them with some const variable and not C #define? |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
| 335 ↗ | (On Diff #37375) | I find it a bit unclear that we are using true/false to device between content and notifications accounts when reading the code. I wonder if it wouldn't be better to just allow the programmer to pass the ID which is defined as a constant, similar to what we use for secure store: CommSecureStore::set(CommSecureStore::userID, ""); But up to you, I don't think it matters a lot. |
| web/database/types/sqlite-query-executor.js | ||
| 106–111 ↗ | (On Diff #37375) | |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 335 ↗ | (On Diff #37375) | I also think using ID instead of flag makes more sense |