[web] fix regression in error handling
ClosedPublic
Actions

Authored by varun on Mar 1 2024, 12:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 29, 6:08 PM

	Unknown Object (File)
	Tue, Dec 17, 12:38 AM

	Unknown Object (File)
	Tue, Dec 17, 12:38 AM

	Unknown Object (File)
	Tue, Dec 17, 12:38 AM

	Unknown Object (File)
	Tue, Dec 17, 12:38 AM

	Unknown Object (File)
	Fri, Dec 13, 11:40 PM

	Unknown Object (File)
	Nov 28 2024, 3:58 AM

	Unknown Object (File)
	Nov 24 2024, 12:21 PM

View All 55 Files

Subscribers

tomek

Details

Reviewers

ashoat

Commits

rCOMMdadf56db5def: [web] fix regression in error handling

Summary

if the password is wrong we shouldn't display the unknown error text

Depends on D11194

Test Plan

confirmed that the "incorrect username or password" text displays now when the password is incorrect

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Mar 1 2024, 12:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 1 2024, 12:37 PM

varun added inline comments.Mar 1 2024, 12:38 PM

web/account/traditional-login-form.react.js
128 ↗	(On Diff #37733)	task to improve message

Harbormaster completed remote builds in B27256: Diff 37733.Mar 1 2024, 12:53 PM

varun requested review of this revision.Mar 1 2024, 12:53 PM

ashoat accepted this revision.Mar 1 2024, 3:08 PM

This revision is now accepted and ready to land.Mar 1 2024, 3:08 PM

Closed by commit rCOMMdadf56db5def: [web] fix regression in error handling (authored by varun). · Explain WhyMar 5 2024, 12:46 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMdadf56db5def: [web] fix regression in error handling.

Revision Contents
Changeset List

Path

Size

web/

account/

traditional-login-form.react.js

9 lines

Diff 37862

View Options

web/account/traditional-login-form.react.js

[web] fix regression in error handlingClosedPublicActions