Page MenuHomePhabricator
Differential D11243

[CI] Clean on failure for Emscripten pipeline
Changes PlannedPublic
Actions

Authored by kamil on Mar 5 2024, 4:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 1:26 PM
Unknown Object (File)
Thu, Apr 25, 1:02 PM
Unknown Object (File)
Thu, Apr 25, 1:02 PM
Unknown Object (File)
Thu, Apr 25, 1:02 PM
Unknown Object (File)
Thu, Apr 25, 1:02 PM
Unknown Object (File)
Thu, Apr 25, 1:02 PM
Unknown Object (File)
Thu, Apr 25, 1:02 PM
Unknown Object (File)
Mon, Apr 22, 2:20 AM
View All 28 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
atul
Summary

Potential fix for ENG-7092.
Context in ENG-6977 and ENG-6879.

Now this pipeline has two steps:
Emscripten build - build WASM and compare
Clean on failure and Emscripten build - cleans all caches, builds, and compares again

Test Plan

Tested on CI:

  1. Make sure Clean on failure and Emscripten build cleans only when step Emscripten build fails
  2. Make sure Clean on failure and Emscripten build actually cleans files (looked at logs)
  3. On Emscripten build success Clean on failure and Emscripten build should not perform any actions

Diff Detail

Repository
rCOMM Comm
Branch
clean-on-failure
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Mar 5 2024, 4:08 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 5 2024, 4:08 AM
kamil updated this revision to Diff 37822.Mar 5 2024, 4:17 AM

This should clean

Harbormaster failed remote builds in B27329: Diff 37822!Mar 5 2024, 4:29 AM
Harbormaster completed remote builds in B27328: Diff 37821.Mar 5 2024, 4:35 AM
kamil updated this revision to Diff 37824.Mar 5 2024, 5:16 AM

test

Harbormaster failed remote builds in B27331: Diff 37824!Mar 5 2024, 5:24 AM
kamil updated this revision to Diff 37825.Mar 5 2024, 5:28 AM

this should pass

kamil published this revision for review.Mar 5 2024, 5:32 AM
kamil edited the summary of this revision. (Show Details)
kamil edited the test plan for this revision. (Show Details)
kamil added a reviewer: atul. kamil added 1 blocking reviewer(s): michal.
Harbormaster completed remote builds in B27332: Diff 37825.Mar 5 2024, 5:44 AM
michal added inline comments.Mar 5 2024, 5:52 AM
.buildkite/emscripten.yml
19–20

According to the docs, continue_on_failure: true won't change the status of the build, so event if this succeeds I think the build will still fail?

So that means that build-db-wasm and git diff lines aren't really needed here if I understand it correctly.

atul added a comment.Mar 5 2024, 8:23 AM

Will run on the MacBook Air (where it was previously failing) here: https://phab.comm.dev/D11245

kamil planned changes to this revision.Mar 15 2024, 5:39 AM

Revision Contents
Changeset List

PathSize
.buildkite/
17 lines

Diff 37825

View Options

.buildkite/emscripten.yml

Loading...