[keyserver] Transform client IDs when handling socket message
ClosedPublic
Actions

Authored by tomek on Mar 5 2024, 4:41 AM.

Details

Reviewers

atul
inka
michal
marcin

Commits

rCOMMa0b423e3ccf6: [keyserver] Transform client IDs when handling socket message

Summary

When receiving a socket message, the server wasn't transforming the IDs - it caused verifyCalendarQueryThreadIDs to throw because none of the received thread filter IDs were present in the DB.

https://linear.app/comm/issue/ENG-7115/changing-calendar-query-doesnt-work

Test Plan

Add and remove some thread filters and check if the error message no longer occurs. Also check if the actualizedCalendarQuery is correctly updated in the store.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 5 2024, 4:41 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 4:41 AM

Harbormaster completed remote builds in B27330: Diff 37823.Mar 5 2024, 5:04 AM

tomek requested review of this revision.Mar 5 2024, 5:04 AM

michal added inline comments.Mar 5 2024, 5:16 AM

keyserver/src/socket/socket.js
247 ↗	(On Diff #37823)	Just making sure: if the socket message is an API request we won't try to convert the message twice (this would cause errors/warnings)?

tomek added inline comments.Mar 5 2024, 5:58 AM

keyserver/src/socket/socket.js
247 ↗	(On Diff #37823)	We will convert the message twice, and this is intentional. One of the message types we can receive is `clientSocketMessageTypes.API_REQUEST` which goes to our `jsonEndpoints`. This is fine, and doesn't cause repeated ID conversion because `APIRequestClientSocketMessage` contains `APIRequest` which has `input?: Object` (`t.maybe(t.Object)`) - so even if the input contains some IDs, we won't attempt their conversion yet.