Page MenuHomePhabricator
Differential D11270

[lib] Disable edit button when link secret isn't changed
ClosedPublic
Actions

Authored by tomek on Mar 7 2024, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 7 2024, 8:15 PM
Unknown Object (File)
Apr 7 2024, 8:15 PM
Unknown Object (File)
Apr 7 2024, 8:13 PM
Unknown Object (File)
Apr 7 2024, 8:13 PM
Unknown Object (File)
Mar 26 2024, 10:32 PM
Unknown Object (File)
Mar 26 2024, 8:51 PM
Unknown Object (File)
Mar 20 2024, 4:19 PM
Unknown Object (File)
Mar 15 2024, 5:59 PM
View All 13 Files
Subscribers
ashoat

Details

Reviewers
inka
atul
Commits
rCOMM756091f20eca: [lib] Disable edit button when link secret isn't changed
Summary

Enable the button only after the link is changed.

https://linear.app/comm/issue/ENG-7149/edit-link-button-is-active-when-a-link-wasnt-changed

Depends on D11269

Test Plan

Open manage links screen on web and native - the button should be disabled. Change the link - the button should become enabled.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
hooks/
11 lines
native/
invite-links/
3 lines
web/
invite-links/
manage/
12 lines

Diff 37948

View Options

lib/hooks/invite-links.js

Loading...
View Options

native/invite-links/manage-public-link-screen.react.js

Loading...
View Options

web/invite-links/manage/edit-link-modal.react.js

Loading...