Page MenuHomePhabricator
Differential D11270

[lib] Disable edit button when link secret isn't changed
ClosedPublic
Actions

Authored by tomek on Mar 7 2024, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 27 2025, 7:11 PM
Unknown Object (File)
Feb 27 2025, 7:11 PM
Unknown Object (File)
Feb 26 2025, 7:17 AM
Unknown Object (File)
Feb 26 2025, 7:11 AM
Unknown Object (File)
Feb 17 2025, 1:20 PM
Unknown Object (File)
Jan 20 2025, 4:36 AM
Unknown Object (File)
Jan 2 2025, 3:25 AM
Unknown Object (File)
Jan 2 2025, 3:25 AM
View All 61 Files
Subscribers
ashoat

Details

Reviewers
inka
atul
Commits
rCOMM756091f20eca: [lib] Disable edit button when link secret isn't changed
Summary

Enable the button only after the link is changed.

https://linear.app/comm/issue/ENG-7149/edit-link-button-is-active-when-a-link-wasnt-changed

Depends on D11269

Test Plan

Open manage links screen on web and native - the button should be disabled. Change the link - the button should become enabled.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
hooks/
11 lines
native/
invite-links/
3 lines
web/
invite-links/
manage/
12 lines

Diff 37948

View Options

lib/hooks/invite-links.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { getOneTimeKeyValues } from 'lib/shared/crypto-utils.js'; import { getOneTimeKeyValues } from 'lib/shared/crypto-utils.js';
import { IdentityClientContext } from 'lib/shared/identity-client-context.js'; import { IdentityClientContext } from 'lib/shared/identity-client-context.js';
import { import {
type IdentityKeysBlob, type IdentityKeysBlob,
identityKeysBlobValidator, identityKeysBlobValidator,
type OneTimeKeysResultValues, type OneTimeKeysResultValues,
} from 'lib/types/crypto-types.js'; } from 'lib/types/crypto-types.js';
import { import {
type SignedDeviceList, type SignedDeviceList,
signedDeviceListHistoryValidator, signedDeviceListHistoryValidator,
type SignedMessage,
type DeviceOlmOutboundKeys, type DeviceOlmOutboundKeys,
deviceOlmOutboundKeysValidator, deviceOlmOutboundKeysValidator,
type IdentityServiceClient, type IdentityServiceClient,
type UserDevicesOlmOutboundKeys, type UserDevicesOlmOutboundKeys,
type UserAuthMetadata, type UserAuthMetadata,
ONE_TIME_KEYS_NUMBER, ONE_TIME_KEYS_NUMBER,
identityAuthResultValidator, identityAuthResultValidator,
type DeviceOlmInboundKeys, type DeviceOlmInboundKeys,
▲ Show 20 Lines • Show All 422 Lines • ▼ Show 20 Lines () => ({
await commCoreModule.setCommServicesAuthMetadata( await commCoreModule.setCommServicesAuthMetadata(
validatedResult.userID, validatedResult.userID,
primaryIdentityPublicKeys.ed25519, primaryIdentityPublicKeys.ed25519,
validatedResult.accessToken, validatedResult.accessToken,
); );
return validatedResult; return validatedResult;
}, },
uploadKeysForRegisteredDeviceAndLogIn: async (
userID: string,
nonceChallengeResponse: SignedMessage,
) => {
await commCoreModule.initializeCryptoAccount();
const [
{ blobPayload, signature, primaryIdentityPublicKeys },
{ contentOneTimeKeys, notificationsOneTimeKeys },
prekeys,
] = await Promise.all([
commCoreModule.getUserPublicKey(),
commCoreModule.getOneTimeKeys(ONE_TIME_KEYS_NUMBER),
commCoreModule.validateAndGetPrekeys(),
]);
const challengeResponse = JSON.stringify(nonceChallengeResponse);
const registrationResult =
await commRustModule.uploadSecondaryDeviceKeysAndLogIn(
userID,
challengeResponse,
blobPayload,
signature,
prekeys.contentPrekey,
prekeys.contentPrekeySignature,
prekeys.notifPrekey,
prekeys.notifPrekeySignature,
getOneTimeKeyValues(contentOneTimeKeys),
getOneTimeKeyValues(notificationsOneTimeKeys),
);
const { accessToken: token } = JSON.parse(registrationResult);
const identityAuthResult = { accessToken: token, userID, username: '' };
const validatedResult = assertWithValidator(
identityAuthResult,
identityAuthResultValidator,
);
await commCoreModule.setCommServicesAuthMetadata(
validatedResult.userID,
primaryIdentityPublicKeys.ed25519,
validatedResult.accessToken,
);
return validatedResult;
},
generateNonce: commRustModule.generateNonce, generateNonce: commRustModule.generateNonce,
getDeviceListHistoryForUser: async ( getDeviceListHistoryForUser: async (
userID: string, userID: string,
sinceTimestamp?: number, sinceTimestamp?: number,
) => { ) => {
const { const {
deviceID: authDeviceID, deviceID: authDeviceID,
userID: authUserID, userID: authUserID,
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

native/invite-links/manage-public-link-screen.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { getOneTimeKeyValues } from 'lib/shared/crypto-utils.js'; import { getOneTimeKeyValues } from 'lib/shared/crypto-utils.js';
import { IdentityClientContext } from 'lib/shared/identity-client-context.js'; import { IdentityClientContext } from 'lib/shared/identity-client-context.js';
import { import {
type IdentityKeysBlob, type IdentityKeysBlob,
identityKeysBlobValidator, identityKeysBlobValidator,
type OneTimeKeysResultValues, type OneTimeKeysResultValues,
} from 'lib/types/crypto-types.js'; } from 'lib/types/crypto-types.js';
import { import {
type SignedDeviceList, type SignedDeviceList,
signedDeviceListHistoryValidator, signedDeviceListHistoryValidator,
type SignedMessage,
type DeviceOlmOutboundKeys, type DeviceOlmOutboundKeys,
deviceOlmOutboundKeysValidator, deviceOlmOutboundKeysValidator,
type IdentityServiceClient, type IdentityServiceClient,
type UserDevicesOlmOutboundKeys, type UserDevicesOlmOutboundKeys,
type UserAuthMetadata, type UserAuthMetadata,
ONE_TIME_KEYS_NUMBER, ONE_TIME_KEYS_NUMBER,
identityAuthResultValidator, identityAuthResultValidator,
type DeviceOlmInboundKeys, type DeviceOlmInboundKeys,
▲ Show 20 Lines • Show All 422 Lines • ▼ Show 20 Lines () => ({
await commCoreModule.setCommServicesAuthMetadata( await commCoreModule.setCommServicesAuthMetadata(
validatedResult.userID, validatedResult.userID,
primaryIdentityPublicKeys.ed25519, primaryIdentityPublicKeys.ed25519,
validatedResult.accessToken, validatedResult.accessToken,
); );
return validatedResult; return validatedResult;
}, },
uploadKeysForRegisteredDeviceAndLogIn: async (
userID: string,
nonceChallengeResponse: SignedMessage,
) => {
await commCoreModule.initializeCryptoAccount();
const [
{ blobPayload, signature, primaryIdentityPublicKeys },
{ contentOneTimeKeys, notificationsOneTimeKeys },
prekeys,
] = await Promise.all([
commCoreModule.getUserPublicKey(),
commCoreModule.getOneTimeKeys(ONE_TIME_KEYS_NUMBER),
commCoreModule.validateAndGetPrekeys(),
]);
const challengeResponse = JSON.stringify(nonceChallengeResponse);
const registrationResult =
await commRustModule.uploadSecondaryDeviceKeysAndLogIn(
userID,
challengeResponse,
blobPayload,
signature,
prekeys.contentPrekey,
prekeys.contentPrekeySignature,
prekeys.notifPrekey,
prekeys.notifPrekeySignature,
getOneTimeKeyValues(contentOneTimeKeys),
getOneTimeKeyValues(notificationsOneTimeKeys),
);
const { accessToken: token } = JSON.parse(registrationResult);
const identityAuthResult = { accessToken: token, userID, username: '' };
const validatedResult = assertWithValidator(
identityAuthResult,
identityAuthResultValidator,
);
await commCoreModule.setCommServicesAuthMetadata(
validatedResult.userID,
primaryIdentityPublicKeys.ed25519,
validatedResult.accessToken,
);
return validatedResult;
},
generateNonce: commRustModule.generateNonce, generateNonce: commRustModule.generateNonce,
getDeviceListHistoryForUser: async ( getDeviceListHistoryForUser: async (
userID: string, userID: string,
sinceTimestamp?: number, sinceTimestamp?: number,
) => { ) => {
const { const {
deviceID: authDeviceID, deviceID: authDeviceID,
userID: authUserID, userID: authUserID,
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

web/invite-links/manage/edit-link-modal.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { getOneTimeKeyValues } from 'lib/shared/crypto-utils.js'; import { getOneTimeKeyValues } from 'lib/shared/crypto-utils.js';
import { IdentityClientContext } from 'lib/shared/identity-client-context.js'; import { IdentityClientContext } from 'lib/shared/identity-client-context.js';
import { import {
type IdentityKeysBlob, type IdentityKeysBlob,
identityKeysBlobValidator, identityKeysBlobValidator,
type OneTimeKeysResultValues, type OneTimeKeysResultValues,
} from 'lib/types/crypto-types.js'; } from 'lib/types/crypto-types.js';
import { import {
type SignedDeviceList, type SignedDeviceList,
signedDeviceListHistoryValidator, signedDeviceListHistoryValidator,
type SignedMessage,
type DeviceOlmOutboundKeys, type DeviceOlmOutboundKeys,
deviceOlmOutboundKeysValidator, deviceOlmOutboundKeysValidator,
type IdentityServiceClient, type IdentityServiceClient,
type UserDevicesOlmOutboundKeys, type UserDevicesOlmOutboundKeys,
type UserAuthMetadata, type UserAuthMetadata,
ONE_TIME_KEYS_NUMBER, ONE_TIME_KEYS_NUMBER,
identityAuthResultValidator, identityAuthResultValidator,
type DeviceOlmInboundKeys, type DeviceOlmInboundKeys,
▲ Show 20 Lines • Show All 422 Lines • ▼ Show 20 Lines () => ({
await commCoreModule.setCommServicesAuthMetadata( await commCoreModule.setCommServicesAuthMetadata(
validatedResult.userID, validatedResult.userID,
primaryIdentityPublicKeys.ed25519, primaryIdentityPublicKeys.ed25519,
validatedResult.accessToken, validatedResult.accessToken,
); );
return validatedResult; return validatedResult;
}, },
uploadKeysForRegisteredDeviceAndLogIn: async (
userID: string,
nonceChallengeResponse: SignedMessage,
) => {
await commCoreModule.initializeCryptoAccount();
const [
{ blobPayload, signature, primaryIdentityPublicKeys },
{ contentOneTimeKeys, notificationsOneTimeKeys },
prekeys,
] = await Promise.all([
commCoreModule.getUserPublicKey(),
commCoreModule.getOneTimeKeys(ONE_TIME_KEYS_NUMBER),
commCoreModule.validateAndGetPrekeys(),
]);
const challengeResponse = JSON.stringify(nonceChallengeResponse);
const registrationResult =
await commRustModule.uploadSecondaryDeviceKeysAndLogIn(
userID,
challengeResponse,
blobPayload,
signature,
prekeys.contentPrekey,
prekeys.contentPrekeySignature,
prekeys.notifPrekey,
prekeys.notifPrekeySignature,
getOneTimeKeyValues(contentOneTimeKeys),
getOneTimeKeyValues(notificationsOneTimeKeys),
);
const { accessToken: token } = JSON.parse(registrationResult);
const identityAuthResult = { accessToken: token, userID, username: '' };
const validatedResult = assertWithValidator(
identityAuthResult,
identityAuthResultValidator,
);
await commCoreModule.setCommServicesAuthMetadata(
validatedResult.userID,
primaryIdentityPublicKeys.ed25519,
validatedResult.accessToken,
);
return validatedResult;
},
generateNonce: commRustModule.generateNonce, generateNonce: commRustModule.generateNonce,
getDeviceListHistoryForUser: async ( getDeviceListHistoryForUser: async (
userID: string, userID: string,
sinceTimestamp?: number, sinceTimestamp?: number,
) => { ) => {
const { const {
deviceID: authDeviceID, deviceID: authDeviceID,
userID: authUserID, userID: authUserID,
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines