Page MenuHomePhabricator
Differential D11323

[lib] return ops from integrity store reducer
ClosedPublic
Actions

Authored by will on Mar 13 2024, 11:28 PM.
Tags
None
Referenced Files
F5727939: D11323.diff
Mon, Apr 14, 9:03 AM
Unknown Object (File)
Fri, Apr 11, 1:30 PM
Unknown Object (File)
Mon, Mar 31, 5:32 PM
Unknown Object (File)
Sun, Mar 30, 10:27 AM
Unknown Object (File)
Fri, Mar 28, 3:59 PM
Unknown Object (File)
Mon, Mar 24, 3:29 AM
Unknown Object (File)
Feb 20 2025, 10:42 AM
Unknown Object (File)
Feb 20 2025, 10:42 AM
View All 98 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMMdc183ddde9e0: [lib] return ops from integrity store reducer
Summary

This returns ops from integrity store reducer for usage by future diffs

Depends on D11343

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mar 13 2024, 11:28 PM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 13 2024, 11:28 PM
will edited the summary of this revision. (Show Details)Mar 13 2024, 11:35 PM
will added a parent revision: D11322: refactor integrity reducer starting state to use processStoreOps.
will added a child revision: D11300: [sqlite] add methods to operate on integrity store table.
Harbormaster completed remote builds in B27493: Diff 38050.Mar 13 2024, 11:43 PM
will requested review of this revision.Mar 13 2024, 11:43 PM
will updated this revision to Diff 38112.Mar 15 2024, 7:03 PM

refactor for sync state action

Harbormaster completed remote builds in B27543: Diff 38112.Mar 15 2024, 7:18 PM
kamil accepted this revision.Mar 18 2024, 6:23 AM
This revision is now accepted and ready to land.Mar 18 2024, 6:23 AM
will edited the summary of this revision. (Show Details)Mar 18 2024, 6:40 AM
will added a parent revision: D11343: [sqlite] [lib] refactor integrity reducer full state sync action type to use sqlite ops.
will removed a parent revision: D11322: refactor integrity reducer starting state to use processStoreOps.Mar 25 2024, 1:42 PM
Closed by commit rCOMMdc183ddde9e0: [lib] return ops from integrity store reducer (authored by will). · Explain WhyMar 25 2024, 2:11 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMdc183ddde9e0: [lib] return ops from integrity store reducer.

Revision Contents
Changeset List

PathSize
lib/
reducers/
51 lines
14 lines

Diff 38313

View Options

lib/reducers/integrity-reducer.js

Show First 20 Lines • Show All 500 Lines • ▼ Show 20 Lines if (message.type === serverSocketMessageTypes.ERROR) {
currentUserInfo, currentUserInfo,
cookie: newerCookie, cookie: newerCookie,
}, },
preRequestUserState: this.initializedWithUserState, preRequestUserState: this.initializedWithUserState,
error: null, error: null,
logInActionSource: logInActionSource:
logInActionSources.socketAuthErrorResolutionAttempt, logInActionSources.socketAuthErrorResolutionAttempt,
keyserverID: ashoatKeyserverID, keyserverID: ashoatKeyserverID,
urlPrefix: this.props.urlPrefix,
}, },
}); });
} }
this.invalidationRecoveryInProgress = false; this.invalidationRecoveryInProgress = false;
} }
}; };
addListener: (listener: SocketListener) => void = listener => { addListener: (listener: SocketListener) => void = listener => {
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Lines if (stateSyncMessage.payload.type === stateSyncPayloadTypes.FULL) {
this.props.dispatch({ this.props.dispatch({
type: setNewSessionActionType, type: setNewSessionActionType,
payload: { payload: {
sessionChange: { cookieInvalidated: false, sessionID }, sessionChange: { cookieInvalidated: false, sessionID },
preRequestUserState: this.initializedWithUserState, preRequestUserState: this.initializedWithUserState,
error: null, error: null,
logInActionSource: undefined, logInActionSource: undefined,
keyserverID: ashoatKeyserverID, keyserverID: ashoatKeyserverID,
urlPrefix: this.props.urlPrefix,
}, },
}); });
} }
} else { } else {
const { type, ...actionPayload } = stateSyncMessage.payload; const { type, ...actionPayload } = stateSyncMessage.payload;
this.props.dispatch({ this.props.dispatch({
type: incrementalStateSyncActionType, type: incrementalStateSyncActionType,
payload: { payload: {
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines
View Options

lib/reducers/master-reducer.js

Show First 20 Lines • Show All 500 Lines • ▼ Show 20 Lines if (message.type === serverSocketMessageTypes.ERROR) {
currentUserInfo, currentUserInfo,
cookie: newerCookie, cookie: newerCookie,
}, },
preRequestUserState: this.initializedWithUserState, preRequestUserState: this.initializedWithUserState,
error: null, error: null,
logInActionSource: logInActionSource:
logInActionSources.socketAuthErrorResolutionAttempt, logInActionSources.socketAuthErrorResolutionAttempt,
keyserverID: ashoatKeyserverID, keyserverID: ashoatKeyserverID,
urlPrefix: this.props.urlPrefix,
}, },
}); });
} }
this.invalidationRecoveryInProgress = false; this.invalidationRecoveryInProgress = false;
} }
}; };
addListener: (listener: SocketListener) => void = listener => { addListener: (listener: SocketListener) => void = listener => {
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Lines if (stateSyncMessage.payload.type === stateSyncPayloadTypes.FULL) {
this.props.dispatch({ this.props.dispatch({
type: setNewSessionActionType, type: setNewSessionActionType,
payload: { payload: {
sessionChange: { cookieInvalidated: false, sessionID }, sessionChange: { cookieInvalidated: false, sessionID },
preRequestUserState: this.initializedWithUserState, preRequestUserState: this.initializedWithUserState,
error: null, error: null,
logInActionSource: undefined, logInActionSource: undefined,
keyserverID: ashoatKeyserverID, keyserverID: ashoatKeyserverID,
urlPrefix: this.props.urlPrefix,
}, },
}); });
} }
} else { } else {
const { type, ...actionPayload } = stateSyncMessage.payload; const { type, ...actionPayload } = stateSyncMessage.payload;
this.props.dispatch({ this.props.dispatch({
type: incrementalStateSyncActionType, type: incrementalStateSyncActionType,
payload: { payload: {
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines