Page MenuHomePhabricator
Differential D11249

[sqlite] Adds integrity store table
ClosedPublic
Actions

Authored by will on Mar 5 2024, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 7 2024, 8:15 PM
Unknown Object (File)
Apr 7 2024, 8:15 PM
Unknown Object (File)
Apr 7 2024, 8:13 PM
Unknown Object (File)
Apr 7 2024, 8:13 PM
Unknown Object (File)
Apr 7 2024, 5:40 AM
Unknown Object (File)
Mar 31 2024, 2:22 AM
Unknown Object (File)
Mar 29 2024, 5:47 PM
Unknown Object (File)
Mar 16 2024, 3:39 AM
View All 16 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM11debc765fb9: [sqlite] Adds integrity store table
Summary

This adds the integrity store table to sqlite

Depends on D11247

Test Plan

Tested on native and successfully created table viewable in TablePlus.

image.png (944×1 px, 211 KB)

Additionally, received successful migration 36 log

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mar 5 2024, 2:41 PM
will held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptMar 5 2024, 2:41 PM
will edited the test plan for this revision. (Show Details)Mar 5 2024, 2:43 PM
will edited the test plan for this revision. (Show Details)
Harbormaster failed remote builds in B27345: Diff 37866!Mar 5 2024, 2:53 PM
will edited the test plan for this revision. (Show Details)Mar 5 2024, 8:59 PM
will edited the test plan for this revision. (Show Details)
will edited the test plan for this revision. (Show Details)
will published this revision for review.Mar 5 2024, 9:03 PM
will added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
517 ↗(On Diff #37866)

Should we call this something else? integrities maybe?

kamil accepted this revision.Mar 7 2024, 2:25 AM

Could you please form the stack with your diffs?

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
517 ↗(On Diff #37866)

I think integrity_store makes most sense

519 ↗(On Diff #37866)

please match convention

This revision is now accepted and ready to land.Mar 7 2024, 2:25 AM
kamil mentioned this in D11247: [lib] Add integrity store ops.Mar 7 2024, 4:04 AM
will edited the summary of this revision. (Show Details)Mar 7 2024, 11:57 AM
will added a parent revision: D11247: [lib] Add integrity store ops.
will updated this revision to Diff 37959.EditedMar 11 2024, 12:32 AM

Update hash to number from text and review feedback

will updated this revision to Diff 37960.Mar 11 2024, 12:38 AM

add _store to create_integrity_table method

Harbormaster completed remote builds in B27411: Diff 37959.Mar 11 2024, 12:46 AM
Harbormaster failed remote builds in B27412: Diff 37960!Mar 11 2024, 12:50 AM
will updated this revision to Diff 37976.Mar 11 2024, 6:27 AM

build db wasm

Harbormaster completed remote builds in B27428: Diff 37976.Mar 11 2024, 6:57 AM
will added a child revision: D11287: [lib] refactor integrity reducer add new thread hashes to use sqlite ops.Mar 11 2024, 2:05 PM
will updated this revision to Diff 38089.Mar 14 2024, 9:40 PM

convert thead hash type to text

Harbormaster failed remote builds in B27523: Diff 38089!Mar 14 2024, 9:56 PM
This revision was landed with ongoing or failed builds.Mar 25 2024, 2:10 PM
Closed by commit rCOMM11debc765fb9: [sqlite] Adds integrity store table (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM11debc765fb9: [sqlite] Adds integrity store table.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
17 lines
web/
shared-worker/
_generated/

Diff 38308

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...