Page MenuHomePhabricator

[sqlite] Adds integrity store table
ClosedPublic

Authored by will on Mar 5 2024, 2:41 PM.
Tags
None
Referenced Files
F3392347: D11249.diff
Sat, Nov 30, 8:22 AM
Unknown Object (File)
Fri, Nov 15, 4:05 PM
Unknown Object (File)
Fri, Nov 8, 5:51 AM
Unknown Object (File)
Wed, Nov 6, 8:03 AM
Unknown Object (File)
Sat, Nov 2, 9:54 AM
Unknown Object (File)
Fri, Nov 1, 8:39 PM
Unknown Object (File)
Oct 24 2024, 2:45 PM
Unknown Object (File)
Oct 17 2024, 1:55 PM
Subscribers

Details

Summary

This adds the integrity store table to sqlite

Depends on D11247

Test Plan

Tested on native and successfully created table viewable in TablePlus.

image.png (944×1 px, 211 KB)

Additionally, received successful migration 36 log

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will held this revision as a draft.
will edited the test plan for this revision. (Show Details)
will edited the test plan for this revision. (Show Details)
will edited the test plan for this revision. (Show Details)
will published this revision for review.Mar 5 2024, 9:03 PM
will added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
517 ↗(On Diff #37866)

Should we call this something else? integrities maybe?

Could you please form the stack with your diffs?

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
517 ↗(On Diff #37866)

I think integrity_store makes most sense

519 ↗(On Diff #37866)

please match convention

This revision is now accepted and ready to land.Mar 7 2024, 2:25 AM

Update hash to number from text and review feedback

add _store to create_integrity_table method

convert thead hash type to text

This revision was landed with ongoing or failed builds.Mar 25 2024, 2:10 PM
This revision was automatically updated to reflect the committed changes.