Paths

Table of Contentst

[protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList
ClosedPublic
Actions

Authored by bartek on Mar 25 2024, 7:00 AM.

Details

Reviewers

varun
ashoat

Commits

rCOMM9f580a5f8191: [protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList

Summary

Addresses ENG-6839

The ForUser suffix suffix should be only when request contains [non-caller] user_id

Test Plan

Identity and native compiles

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 25 2024, 7:00 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMar 25 2024, 7:00 AM

bartek added a child revision: D11379: [protos][identity] Add RPC to find username by user ID.Mar 25 2024, 7:03 AM

Harbormaster failed remote builds in B27663: Diff 38285!Mar 25 2024, 7:22 AM

Fix commtest

Harbormaster completed remote builds in B27665: Diff 38288.Mar 25 2024, 8:01 AM

bartek published this revision for review.Mar 25 2024, 8:02 AM

ashoat accepted this revision.Mar 26 2024, 12:47 PM

This revision is now accepted and ready to land.Mar 26 2024, 12:47 PM

Closed by commit rCOMM9f580a5f8191: [protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList (authored by bartek). · Explain WhyMar 28 2024, 12:03 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9f580a5f8191: [protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

lib.rs

4 lines

services/

commtest/

tests/

identity_device_list_tests.rs

2 lines

identity/

src/

grpc_services/

authenticated.rs

2 lines

shared/

protos/

identity_auth.proto

2 lines

web/

protobufs/

identity-auth-client.cjs

identity-auth-client.cjs.flow

4 lines

Diff 38420

View Options

native/native_rust_library/src/lib.rs

View Options

services/commtest/tests/identity_device_list_tests.rs

View Options

services/identity/src/grpc_services/authenticated.rs

View Options

shared/protos/identity_auth.proto

View Options

web/protobufs/identity-auth-client.cjs

View Options

web/protobufs/identity-auth-client.cjs.flow

[protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceListClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38420

native/native_rust_library/src/lib.rs

services/commtest/tests/identity_device_list_tests.rs

services/identity/src/grpc_services/authenticated.rs

shared/protos/identity_auth.proto

web/protobufs/identity-auth-client.cjs

web/protobufs/identity-auth-client.cjs.flow

[protos] Rename UpdateDeviceListForUser RPC to UpdateDeviceList
ClosedPublic
Actions

Revision Contents
Changeset List