Paths

Table of Contentst

Differential D11465

[protos] Add RPC to log in existing device
ClosedPublic
Actions

Authored by bartek on Mar 28 2024, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 12, 10:22 PM

	Unknown Object (File)
	Tue, Nov 12, 9:15 PM

	Unknown Object (File)
	Oct 18 2024, 6:26 PM

	Unknown Object (File)
	Oct 18 2024, 6:26 PM

	Unknown Object (File)
	Oct 18 2024, 6:26 PM

	Unknown Object (File)
	Oct 18 2024, 6:23 PM

	Unknown Object (File)
	Oct 11 2024, 10:34 AM

	Unknown Object (File)
	Sep 18 2024, 8:19 AM

View All 53 Files

Subscribers

Details

Reviewers

ashoat
varun

Commits

rCOMMeee910d34fc8: [protos] Add RPC to log in existing device

Summary

Adds Existing device login RPC from ENG-6828 to the proto.

Depends on D11435

Test Plan

Only proto changes here + stub code. Everything should compile.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 28 2024, 10:41 PM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMar 28 2024, 10:41 PM

bartek added a child revision: D11466: [identity] Implement LogInExistingDevice RPC.Mar 28 2024, 10:45 PM

Harbormaster completed remote builds in B27807: Diff 38524.Mar 28 2024, 10:55 PM

bartek published this revision for review.Mar 28 2024, 11:49 PM

ashoat accepted this revision.Mar 29 2024, 10:48 AM

ashoat added inline comments.

shared/protos/identity_unauth.proto
226 ↗	(On Diff #38524)	I think it would be helpful to rename this so it's clear what the "challenge" is. For instance, how about `signed_nonce`?

varun accepted this revision.Mar 29 2024, 12:21 PM

This revision is now accepted and ready to land.Mar 29 2024, 12:21 PM

bartek added inline comments.Mar 30 2024, 1:02 AM

shared/protos/identity_unauth.proto
226 ↗	(On Diff #38524)	I followed the `SecondaryDeviceKeysUploadRequest` format where we call it `challenge_response`. We can either: Rename both Add a comment to both describing what this field is Follow up discussions about the `Identity.social_proof` field being split into two, and split this one into `nonce_message` and `nonce_signature` (much more work both client- and server-side)

ashoat added inline comments.Mar 30 2024, 1:02 PM

shared/protos/identity_unauth.proto
226 ↗	(On Diff #38524)	`nonce_message` is basically just `nonce`, right? I think it would probably be good to split it for consistency... I think we'll save time in the long term by trying to finalize RPCs early instead of adding backlog tasks to change them later

bartek added inline comments.Apr 3 2024, 2:53 AM

shared/protos/identity_unauth.proto
226 ↗	(On Diff #38524)	I'll add a comment now and do the rename in a separate diff to both RPCs https://linear.app/comm/issue/ENG-7641/consider-renaming-challenge-response

Rebase, add comments explaining challenge response

Harbormaster completed remote builds in B27931: Diff 38703.Apr 3 2024, 3:08 AM

Closed by commit rCOMMeee910d34fc8: [protos] Add RPC to log in existing device (authored by bartek). · Explain WhyApr 3 2024, 3:17 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMeee910d34fc8: [protos] Add RPC to log in existing device.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

13 lines

shared/

protos/

identity_unauth.proto

11 lines

web/

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

24 lines

identity-unauth.cjs

identity-unauth.cjs.flow

12 lines

Diff 38710

services/identity/src/client_service.rs

Loading...

shared/protos/identity_unauth.proto

Loading...

web/protobufs/identity-unauth-structs.cjs

Loading...

web/protobufs/identity-unauth-structs.cjs.flow

Loading...

web/protobufs/identity-unauth.cjs

Loading...

web/protobufs/identity-unauth.cjs.flow

Loading...