Page MenuHomePhabricator

[native] Make thumbnail failed when main upload fails
ClosedPublic

Authored by ashoat on Mar 29 2024, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 10:44 PM
Unknown Object (File)
Wed, Jun 12, 1:23 PM
Unknown Object (File)
Tue, Jun 11, 9:19 PM
Unknown Object (File)
Thu, Jun 6, 6:14 AM
Unknown Object (File)
May 7 2024, 3:49 PM
Unknown Object (File)
May 7 2024, 3:49 PM
Unknown Object (File)
May 7 2024, 3:49 PM
Unknown Object (File)
May 7 2024, 3:49 PM
Subscribers

Details

Summary

We currently track a video upload and thumbnail upload together, and call handleUploadFailure once when either of them fail. We should mark them both as failed, so the thumbnail doesn't appear to be "in progress" from the perspective of InputState.uploadInProgress.

This fixes report upload on video message retry, which was previously broken because the thumbnail would appear as in progress to InputState.uploadInProgress, which is checked in canSendReports.

I considered teasing apart the thumbnail upload so it could tracked on its own, and wouldn't need to be retried if the main upload fails. However this looked to be a more significant investment than I have the time to focus on right now.

Linear task: ENG-7600

Depends on D11476

Test Plan

Confirm that when I retry a failed video upload, I see a SEND_REPORT_SUCCESS action

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable