Page MenuHomePhabricator

[lib][web][landing] Don't include injectedWallet in mobile experience
ClosedPublic

Authored by ashoat on Mar 30 2024, 3:24 PM.
Tags
None
Referenced Files
F3345777: D11490.diff
Fri, Nov 22, 6:57 AM
Unknown Object (File)
Sat, Nov 16, 11:52 AM
Unknown Object (File)
Sat, Nov 16, 11:45 AM
Unknown Object (File)
Sat, Nov 16, 11:37 AM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Unknown Object (File)
Wed, Nov 13, 1:42 PM
Subscribers

Details

Summary

The login flow for mobile uses landing, while the on for web is contained within web.

In earlier versions of Rainbowkit/Wagmi, we could include injectedWallet and it would be hidden when viewed from a mobile device.

It's now being included, which isn't desirable for us since our login flow for mobile is rendered instead of a WebView on native.

This diff lets us use a different set of wallets for web and landing, with injectedWallet being excluded by landing.

Depends on D11489

Test Plan

Made sure that "desktop wallet" appears in the desktop SIWE experience and not the mobile SIWE experience

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 3:30 PM
Harbormaster failed remote builds in B27838: Diff 38571!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 3:51 PM
Harbormaster failed remote builds in B27843: Diff 38576!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:14 PM
Harbormaster failed remote builds in B27848: Diff 38581!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:33 PM
Harbormaster failed remote builds in B27853: Diff 38586!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:49 PM
Harbormaster failed remote builds in B27858: Diff 38591!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 5:07 PM
Harbormaster failed remote builds in B27863: Diff 38596!
This revision is now accepted and ready to land.Apr 1 2024, 9:25 AM