Page MenuHomePhabricator

[native][landing] Fix up mobile SIWE flow after Wagmi and Rainbowkit updates
ClosedPublic

Authored by ashoat on Mar 30 2024, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 7:02 AM
Unknown Object (File)
Fri, Nov 22, 6:57 AM
Unknown Object (File)
Mon, Nov 18, 5:11 AM
Unknown Object (File)
Sat, Nov 16, 5:16 PM
Unknown Object (File)
Wed, Nov 13, 1:41 PM
Unknown Object (File)
Wed, Nov 13, 1:41 PM
Unknown Object (File)
Wed, Nov 13, 1:41 PM
Unknown Object (File)
Wed, Nov 13, 1:41 PM
Subscribers

Details

Summary

Some changes here:

  1. The main Rainbowkit modal doesn't reappear anymore when the WalletConnect sub-modal is dismissed. As a result, I've made some changes in landing/siwe.react.js which cause { type: 'siwe_closed' } to be passed to native when BOTH modals are not visible and a signer does not appear within 500ms.
  2. The 500ms timeout mentioned above was previously 250ms. I found it necessary to increase during testing.
  3. I've updated SIWEPanel to avoid resizing the WebView back to Rainbowkit size when the WalletConnect modal is dismissed. There's no point to doing this, since the Rainbowkit content doesn't display anyways, and the changes described above cause the WebView to be immediately closed anyways.

Depends on D11490

Test Plan

Testing closing main modal, closing WalletConnect modal, and WalletConnect modal workflow end-to-end in an iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 3:31 PM
Harbormaster failed remote builds in B27839: Diff 38572!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 3:52 PM
Harbormaster failed remote builds in B27844: Diff 38577!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:16 PM
Harbormaster failed remote builds in B27849: Diff 38582!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:34 PM
Harbormaster failed remote builds in B27854: Diff 38587!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 4:50 PM
Harbormaster failed remote builds in B27859: Diff 38592!
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 30 2024, 5:08 PM
Harbormaster failed remote builds in B27864: Diff 38597!
This revision is now accepted and ready to land.Apr 1 2024, 9:26 AM