Page MenuHomePhabricator
Differential D11494

[lib][native] Update useRegistrationServerCall to set FID in FIDContext
ClosedPublic
Actions

Authored by ashoat on Mar 31 2024, 6:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 3:26 AM
Unknown Object (File)
Sun, Nov 24, 1:40 AM
Unknown Object (File)
Wed, Nov 13, 7:57 PM
Unknown Object (File)
Wed, Nov 13, 7:57 PM
Unknown Object (File)
Wed, Nov 13, 7:57 PM
Unknown Object (File)
Tue, Nov 12, 4:44 PM
Unknown Object (File)
Tue, Nov 12, 4:44 PM
Unknown Object (File)
Tue, Nov 12, 3:32 PM
View All 68 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMM631f31484198: [lib][native] Update useRegistrationServerCall to set FID in FIDContext
Summary

This diff updates useRegistrationServerCall to pull FID from React Navigation params and to set it in FIDContext.

Test Plan

Tested in combination with the rest of the Farcaster stack during the Hackathon

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/farcaster
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 31 2024, 6:16 AM
Herald added a subscriber: tomek. · View Herald TranscriptMar 31 2024, 6:16 AM
ashoat retitled this revision from [lib][native] Update useRegistrationServerCall to set FID on identity and locally to [lib][native] Update useRegistrationServerCall to set FID in FIDContext.Mar 31 2024, 6:21 AM
ashoat edited the summary of this revision. (Show Details)
ashoat removed a reviewer: varun.
ashoat updated this revision to Diff 38605.Mar 31 2024, 6:22 AM
ashoat added a reviewer: varun.

Split the identity service stuff out into a separate diff

ashoat removed a reviewer: varun.Mar 31 2024, 6:22 AM
ashoat added a child revision: D11495: [lib][native] Pass FID from useRegistrationServerCall to identity service during registration.Mar 31 2024, 6:23 AM
Harbormaster failed remote builds in B27871: Diff 38604!Mar 31 2024, 6:28 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 31 2024, 6:33 AM
Harbormaster failed remote builds in B27872: Diff 38605!
ashoat updated this revision to Diff 38607.Mar 31 2024, 9:59 AM

Flow fixes

ashoat added inline comments.Mar 31 2024, 10:00 AM
lib/components/fid-provider.react.js
6 ↗(On Diff #38607)

It should be possible to unset the FID

Harbormaster completed remote builds in B27874: Diff 38607.Mar 31 2024, 10:14 AM
ashoat requested review of this revision.Mar 31 2024, 10:14 AM
ginsu accepted this revision.Apr 1 2024, 11:38 AM
This revision is now accepted and ready to land.Apr 1 2024, 11:38 AM
Closed by commit rCOMM631f31484198: [lib][native] Update useRegistrationServerCall to set FID in FIDContext (authored by ashoat). · Explain WhyApr 1 2024, 5:55 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM631f31484198: [lib][native] Update useRegistrationServerCall to set FID in FIDContext.

Revision Contents
Changeset List

PathSize
lib/
actions/
2 lines
types/
7 lines
native/
account/
registration/
23 lines
16 lines
identity-service/
11 lines

Diff 38604

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/types/siwe-types.js

Loading...
View Options

native/account/registration/registration-server-call.js

Loading...
View Options

native/account/siwe-hooks.js

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...