Page MenuHomePhabricator
Differential D11496

[lib] Fix keyserver sending updated RoleInfos to old clients
ClosedPublic
Actions

Authored by ashoat on Mar 31 2024, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 25, 8:44 AM
Unknown Object (File)
Tue, Mar 25, 7:10 AM
Unknown Object (File)
Tue, Mar 25, 3:04 AM
Unknown Object (File)
Mon, Mar 24, 6:30 AM
Unknown Object (File)
Mar 5 2025, 5:09 AM
Unknown Object (File)
Mar 1 2025, 6:12 PM
Unknown Object (File)
Feb 18 2025, 6:51 PM
Unknown Object (File)
Feb 18 2025, 6:51 PM
View All 70 Files
Subscribers
atul
tomek

Details

Reviewers
atul
Commits
rCOMMfe3428384c93: [lib] Fix keyserver sending updated RoleInfos to old clients
Summary

@atul's recent changes caused a major issue where new RoleInfos were being delivered to older clients, causing validation failures.

This diff makes it so keyserver can continue outputting the old-style RoleInfos to current clients.

Test Plan

I deployed this to prod and:

  1. Confirmed web app refreshed without issue
  2. Confirmed web app could log out / back in
  3. Confirmed native could receive a message without seeing validation errors
  4. Confirmed native could press a notif without seeing validation errors
  5. Confirmed native could log out / back in

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/fixprod
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 31 2024, 7:14 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 31 2024, 7:14 PM
ashoat published this revision for review.Mar 31 2024, 7:15 PM
Harbormaster completed remote builds in B27876: Diff 38609.Mar 31 2024, 7:30 PM
atul accepted this revision.Apr 1 2024, 12:43 PM

Thanks for catching and resolving this.

I definitely thought through this scenario, specifically when I introduced https://phab.comm.dev/D11286... shouldn't have missed it.

This revision is now accepted and ready to land.Apr 1 2024, 12:43 PM
Closed by commit rCOMMfe3428384c93: [lib] Fix keyserver sending updated RoleInfos to old clients (authored by ashoat). · Explain WhyApr 1 2024, 5:55 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMfe3428384c93: [lib] Fix keyserver sending updated RoleInfos to old clients.

Revision Contents
Changeset List

Diff 38609

View Options

lib/permissions/minimally-encoded-raw-thread-info-validators.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Show All 34 Lines
import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js'; import { AlchemyENSCacheProvider, wagmiConfig } from 'lib/utils/wagmi-utils.js';
import QrCodeLogin from './account/qr-code-login.react.js'; import QrCodeLogin from './account/qr-code-login.react.js';
import AppThemeWrapper from './app-theme-wrapper.react.js'; import AppThemeWrapper from './app-theme-wrapper.react.js';
import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js'; import WebEditThreadAvatarProvider from './avatars/web-edit-thread-avatar-provider.react.js';
import Calendar from './calendar/calendar.react.js'; import Calendar from './calendar/calendar.react.js';
import Chat from './chat/chat.react.js'; import Chat from './chat/chat.react.js';
import { EditModalProvider } from './chat/edit-message-provider.js'; import { EditModalProvider } from './chat/edit-message-provider.js';
import { TooltipProvider } from './chat/tooltip-provider.js';
import NavigationArrows from './components/navigation-arrows.react.js'; import NavigationArrows from './components/navigation-arrows.react.js';
import { initOpaque } from './crypto/opaque-utils.js'; import { initOpaque } from './crypto/opaque-utils.js';
import electron from './electron.js'; import electron from './electron.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
import InviteLinkHandler from './invite-links/invite-link-handler.react.js'; import InviteLinkHandler from './invite-links/invite-link-handler.react.js';
import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js'; import InviteLinksRefresher from './invite-links/invite-links-refresher.react.js';
import LoadingIndicator from './loading-indicator.react.js'; import LoadingIndicator from './loading-indicator.react.js';
import { MenuProvider } from './menu-provider.react.js'; import { MenuProvider } from './menu-provider.react.js';
Show All 15 Lines
import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js'; import { createTunnelbrokerInitMessage } from './selectors/tunnelbroker-selectors.js';
import AccountSettings from './settings/account-settings.react.js'; import AccountSettings from './settings/account-settings.react.js';
import DangerZone from './settings/danger-zone.react.js'; import DangerZone from './settings/danger-zone.react.js';
import KeyserverSelectionList from './settings/keyserver-selection-list.react.js'; import KeyserverSelectionList from './settings/keyserver-selection-list.react.js';
import CommunityPicker from './sidebar/community-picker.react.js'; import CommunityPicker from './sidebar/community-picker.react.js';
import Splash from './splash/splash.react.js'; import Splash from './splash/splash.react.js';
import './typography.css'; import './typography.css';
import css from './style.css'; import css from './style.css';
import { TooltipProvider } from './tooltips/tooltip-provider.js';
import { type NavInfo } from './types/nav-types.js'; import { type NavInfo } from './types/nav-types.js';
import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js'; import { canonicalURLFromReduxState, navInfoFromURL } from './url-utils.js';
void initOpaque(); void initOpaque();
// We want Webpack's css-loader and style-loader to handle the Fontawesome CSS, // We want Webpack's css-loader and style-loader to handle the Fontawesome CSS,
// so we disable the autoAddCss logic and import the CSS file. Otherwise every // so we disable the autoAddCss logic and import the CSS file. Otherwise every
// icon flashes huge for a second before the CSS is loaded. // icon flashes huge for a second before the CSS is loaded.
▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines