Page MenuHomePhabricator
Differential D11548

[identity] Store social proof as a Map in DDB
ClosedPublic
Actions

Authored by bartek on Thu, Apr 4, 4:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 3:05 PM
Unknown Object (File)
Sat, Apr 27, 11:09 AM
Unknown Object (File)
Mon, Apr 22, 6:11 PM
Unknown Object (File)
Sun, Apr 21, 9:46 PM
Unknown Object (File)
Wed, Apr 17, 2:27 AM
Unknown Object (File)
Thu, Apr 11, 12:31 AM
Unknown Object (File)
Thu, Apr 11, 12:10 AM
Unknown Object (File)
Wed, Apr 10, 1:45 PM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
Commits
rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB
Summary

Instead of JSON-serializing and deserializing social proof, we can store it directly as a map attribute in DDB.

NOTE: Note this is breaking change - previous users with String social proof in DDB will fail. I found only 3 wallet users on staging and none on prod. I prefer manually migrating (or deleting) these 3 rows instead of keeping this code backwards compatible

Depends on D11547

Test Plan
  • Added unit test
  • Registered a wallet user and called FindUserIdentity to make sure that social proof is retrieved

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Thu, Apr 4, 4:24 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 4, 4:24 AM
Harbormaster failed remote builds in B27967: Diff 38762!Thu, Apr 4, 4:46 AM
bartek updated this revision to Diff 38765.Thu, Apr 4, 4:49 AM

Rebase

bartek edited the summary of this revision. (Show Details)Thu, Apr 4, 4:51 AM
Harbormaster failed remote builds in B27969: Diff 38765!Thu, Apr 4, 4:54 AM
bartek mentioned this in D11547: [protos] Refactor user Identity message type.Thu, Apr 4, 5:06 AM
Harbormaster completed remote builds in B27969: Diff 38765.Thu, Apr 4, 5:10 AM
bartek published this revision for review.Thu, Apr 4, 5:11 AM
bartek added a child revision: D11549: [protos] Remove social_proof from IdentityKeyInfo.Thu, Apr 4, 5:44 AM
varun accepted this revision.Thu, Apr 4, 8:22 PM
varun added inline comments.
services/identity/src/siwe.rs
151 ↗(On Diff #38765)

nit: maybe this should be named something else instead of deserialized, like social_proof_from_attr

This revision is now accepted and ready to land.Thu, Apr 4, 8:22 PM
bartek updated this revision to Diff 39073.Fri, Apr 12, 3:27 AM

Rebase, Rename variable

Harbormaster completed remote builds in B28184: Diff 39073.Fri, Apr 12, 3:46 AM
Closed by commit rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB (authored by bartek). · Explain WhyMon, Apr 15, 1:44 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
8 lines
4 lines
6 lines
11 lines
grpc_services/
6 lines
34 lines
72 lines

Diff 39105

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/ddb_utils.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

services/identity/src/grpc_utils.rs

Loading...
View Options

services/identity/src/siwe.rs

Loading...