Page MenuHomePhabricator
Differential D11555

[web] Lift WagmiProvider higher up the component tree
ClosedPublic
Actions

Authored by ashoat on Apr 4 2024, 10:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 4:59 AM
Unknown Object (File)
Sat, Mar 8, 4:59 AM
Unknown Object (File)
Sat, Mar 8, 4:59 AM
Unknown Object (File)
Sat, Mar 8, 4:59 AM
Unknown Object (File)
Sat, Mar 8, 4:59 AM
Unknown Object (File)
Sat, Mar 8, 4:59 AM
Unknown Object (File)
Jan 23 2025, 7:09 PM
Unknown Object (File)
Jan 23 2025, 6:07 PM
View All 82 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMMc63d11f6386d: [web] Lift WagmiProvider higher up the component tree
Summary

This resolves ENG-7642. More details about what's going on here.

Depends on D11554

Test Plan

I confirmed that the SIWE flow still works on web

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 4 2024, 10:33 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 4 2024, 10:33 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 4 2024, 10:54 AM
Harbormaster failed remote builds in B27981: Diff 38783!
ashoat added a comment.Apr 4 2024, 12:31 PM

The error is now popping up in other places unfortunately

ashoat updated this revision to Diff 38801.Apr 4 2024, 12:48 PM

Change approach

ashoat retitled this revision from [web] Pass reconnectOnMount={false} to WagmiProvider to [web] Lift WagmiProvider higher up the component tree.Apr 4 2024, 12:52 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 4 2024, 1:24 PM
Harbormaster failed remote builds in B27997: Diff 38801!
ashoat updated this revision to Diff 38813.Apr 4 2024, 1:39 PM

Rebase

Harbormaster completed remote builds in B28004: Diff 38813.Apr 4 2024, 1:56 PM
ashoat requested review of this revision.Apr 4 2024, 1:56 PM
ginsu accepted this revision.Apr 4 2024, 2:03 PM
This revision is now accepted and ready to land.Apr 4 2024, 2:03 PM
Closed by commit rCOMMc63d11f6386d: [web] Lift WagmiProvider higher up the component tree (authored by ashoat). · Explain WhyApr 4 2024, 7:43 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMc63d11f6386d: [web] Lift WagmiProvider higher up the component tree.

Revision Contents
Changeset List

PathSize
web/
51 lines
47 lines

Diff 38824

View Options

web/app.react.js

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Linesfunction getVideoProcessingPlan(input: Input): Plan {
} }
const outputFilename = replaceExtension( const outputFilename = replaceExtension(
`transcode.${uuid}.${sanitizedFilename}`, `transcode.${uuid}.${sanitizedFilename}`,
'mp4', 'mp4',
); );
const outputPath = `${outputDirectory}${outputFilename}`; const outputPath = `${outputDirectory}${outputFilename}`;
let quality, speed, scale; let hardwareAcceleration, quality, speed, scale, pixelFormat;
if (outputCodec === 'h264') { if (outputCodec === 'h264_mediacodec') {
const { floor, min, max, log2 } = Math; hardwareAcceleration = 'mediacodec';
const crf = floor(min(5, max(0, log2(inputDuration / 5)))) + 23; quality = '';
quality = `-crf ${crf}`; speed = '';
speed = '-preset ultrafast';
scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`; scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`;
pixelFormat = '';
} else if (outputCodec === 'h264_videotoolbox') { } else if (outputCodec === 'h264_videotoolbox') {
hardwareAcceleration = 'videotoolbox';
quality = '-profile:v baseline'; quality = '-profile:v baseline';
speed = '-realtime 1'; speed = '-realtime 1';
const { width, height } = inputDimensions; const { width, height } = inputDimensions;
scale = ''; scale = '';
const exceedsDimensions = width > maxWidth || height > maxHeight; const exceedsDimensions = width > maxWidth || height > maxHeight;
if (exceedsDimensions && width / height > maxWidth / maxHeight) { if (exceedsDimensions && width / height > maxWidth / maxHeight) {
scale = `-vf scale=${maxWidth}:-1`; scale = `-vf scale=${maxWidth}:-1`;
} else if (exceedsDimensions) { } else if (exceedsDimensions) {
scale = `-vf scale=-1:${maxHeight}`; scale = `-vf scale=-1:${maxHeight}`;
} }
pixelFormat = '-pix_fmt yuv420p';
} else { } else {
invariant(false, `unrecognized outputCodec ${outputCodec}`); invariant(false, `unrecognized outputCodec ${outputCodec}`);
} }
const ffmpegCommand = const ffmpegCommand =
`-hwaccel ${hardwareAcceleration} ` +
`-i ${inputPath} ` + `-i ${inputPath} ` +
`-c:a copy -c:v ${outputCodec} ` + `-c:a copy -c:v ${outputCodec} ` +
`${quality} ` + `${quality} ` +
'-vsync 2 -r 30 ' + '-fps_mode cfr -r 30 ' +
`${scale} ` + `${scale} ` +
`${speed} ` + `${speed} ` +
'-movflags +faststart ' + '-movflags +faststart ' +
'-pix_fmt yuv420p ' + `${pixelFormat} ` +
'-v quiet ' + '-v quiet ' +
outputPath; outputPath;
return { action: 'process', thumbnailPath, outputPath, ffmpegCommand }; return { action: 'process', thumbnailPath, outputPath, ffmpegCommand };
} }
function getHasMultipleFramesProbeCommand(path: string): string { function getHasMultipleFramesProbeCommand(path: string): string {
const ffprobeCommand = const ffprobeCommand =
Show All 17 Lines
View Options

web/root.js

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Linesfunction getVideoProcessingPlan(input: Input): Plan {
} }
const outputFilename = replaceExtension( const outputFilename = replaceExtension(
`transcode.${uuid}.${sanitizedFilename}`, `transcode.${uuid}.${sanitizedFilename}`,
'mp4', 'mp4',
); );
const outputPath = `${outputDirectory}${outputFilename}`; const outputPath = `${outputDirectory}${outputFilename}`;
let quality, speed, scale; let hardwareAcceleration, quality, speed, scale, pixelFormat;
if (outputCodec === 'h264') { if (outputCodec === 'h264_mediacodec') {
const { floor, min, max, log2 } = Math; hardwareAcceleration = 'mediacodec';
const crf = floor(min(5, max(0, log2(inputDuration / 5)))) + 23; quality = '';
quality = `-crf ${crf}`; speed = '';
speed = '-preset ultrafast';
scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`; scale = `-vf scale=${maxWidth}:${maxHeight}:force_original_aspect_ratio=decrease`;
pixelFormat = '';
} else if (outputCodec === 'h264_videotoolbox') { } else if (outputCodec === 'h264_videotoolbox') {
hardwareAcceleration = 'videotoolbox';
quality = '-profile:v baseline'; quality = '-profile:v baseline';
speed = '-realtime 1'; speed = '-realtime 1';
const { width, height } = inputDimensions; const { width, height } = inputDimensions;
scale = ''; scale = '';
const exceedsDimensions = width > maxWidth || height > maxHeight; const exceedsDimensions = width > maxWidth || height > maxHeight;
if (exceedsDimensions && width / height > maxWidth / maxHeight) { if (exceedsDimensions && width / height > maxWidth / maxHeight) {
scale = `-vf scale=${maxWidth}:-1`; scale = `-vf scale=${maxWidth}:-1`;
} else if (exceedsDimensions) { } else if (exceedsDimensions) {
scale = `-vf scale=-1:${maxHeight}`; scale = `-vf scale=-1:${maxHeight}`;
} }
pixelFormat = '-pix_fmt yuv420p';
} else { } else {
invariant(false, `unrecognized outputCodec ${outputCodec}`); invariant(false, `unrecognized outputCodec ${outputCodec}`);
} }
const ffmpegCommand = const ffmpegCommand =
`-hwaccel ${hardwareAcceleration} ` +
`-i ${inputPath} ` + `-i ${inputPath} ` +
`-c:a copy -c:v ${outputCodec} ` + `-c:a copy -c:v ${outputCodec} ` +
`${quality} ` + `${quality} ` +
'-vsync 2 -r 30 ' + '-fps_mode cfr -r 30 ' +
`${scale} ` + `${scale} ` +
`${speed} ` + `${speed} ` +
'-movflags +faststart ' + '-movflags +faststart ' +
'-pix_fmt yuv420p ' + `${pixelFormat} ` +
'-v quiet ' + '-v quiet ' +
outputPath; outputPath;
return { action: 'process', thumbnailPath, outputPath, ffmpegCommand }; return { action: 'process', thumbnailPath, outputPath, ffmpegCommand };
} }
function getHasMultipleFramesProbeCommand(path: string): string { function getHasMultipleFramesProbeCommand(path: string): string {
const ffprobeCommand = const ffprobeCommand =
Show All 17 Lines