Page MenuHomePhabricator
Differential D11555

[web] Lift WagmiProvider higher up the component tree
ClosedPublic
Actions

Authored by ashoat on Apr 4 2024, 10:33 AM.
Tags
None
Referenced Files
F2109901: D11555.id.diff
Tue, Jun 25, 5:57 PM
Unknown Object (File)
Sun, Jun 23, 4:19 AM
Unknown Object (File)
Wed, Jun 19, 1:56 AM
Unknown Object (File)
Wed, Jun 19, 1:56 AM
Unknown Object (File)
Wed, Jun 19, 1:56 AM
Unknown Object (File)
Wed, Jun 19, 1:56 AM
Unknown Object (File)
Wed, Jun 19, 1:56 AM
Unknown Object (File)
Wed, Jun 19, 1:56 AM
View All 26 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMMc63d11f6386d: [web] Lift WagmiProvider higher up the component tree
Summary

This resolves ENG-7642. More details about what's going on here.

Depends on D11554

Test Plan

I confirmed that the SIWE flow still works on web

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 4 2024, 10:33 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 4 2024, 10:33 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 4 2024, 10:54 AM
Harbormaster failed remote builds in B27981: Diff 38783!
ashoat added a comment.Apr 4 2024, 12:31 PM

The error is now popping up in other places unfortunately

ashoat updated this revision to Diff 38801.Apr 4 2024, 12:48 PM

Change approach

ashoat retitled this revision from [web] Pass reconnectOnMount={false} to WagmiProvider to [web] Lift WagmiProvider higher up the component tree.Apr 4 2024, 12:52 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 4 2024, 1:24 PM
Harbormaster failed remote builds in B27997: Diff 38801!
ashoat updated this revision to Diff 38813.Apr 4 2024, 1:39 PM

Rebase

Harbormaster completed remote builds in B28004: Diff 38813.Apr 4 2024, 1:56 PM
ashoat requested review of this revision.Apr 4 2024, 1:56 PM
ginsu accepted this revision.Apr 4 2024, 2:03 PM
This revision is now accepted and ready to land.Apr 4 2024, 2:03 PM
Closed by commit rCOMMc63d11f6386d: [web] Lift WagmiProvider higher up the component tree (authored by ashoat). · Explain WhyApr 4 2024, 7:43 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMc63d11f6386d: [web] Lift WagmiProvider higher up the component tree.

Revision Contents
Changeset List

PathSize
web/
51 lines
47 lines

Diff 38824

View Options

web/app.react.js

Loading...
View Options

web/root.js

Loading...