Paths

Table of Contentst

[web] Use getMessageForException in shared worker connectHandler
ClosedPublic
Actions

Authored by ashoat on Apr 4 2024, 2:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 24, 12:44 AM

	Unknown Object (File)
	Fri, Sep 20, 4:27 PM

	Unknown Object (File)
	Thu, Aug 29, 4:05 PM

	Unknown Object (File)
	Aug 26 2024, 10:43 AM

	Unknown Object (File)
	Aug 25 2024, 7:01 AM

	Unknown Object (File)
	Aug 24 2024, 8:02 AM

	Unknown Object (File)
	Aug 15 2024, 7:21 PM

	Unknown Object (File)
	Aug 14 2024, 7:16 AM

View All 34 Files

Subscribers

tomek

Details

Reviewers

michal
will

Commits

rCOMM37b88717c320: [web] Use getMessageForException in shared worker connectHandler

Summary

This is safer, since technically in JS anything can be thrown (doesn't have to be an Error)

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 4 2024, 2:48 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 4 2024, 2:48 PM

Harbormaster completed remote builds in B28005: Diff 38814.Apr 4 2024, 3:04 PM

ashoat requested review of this revision.Apr 4 2024, 3:04 PM

will accepted this revision.Apr 4 2024, 9:48 PM

This revision is now accepted and ready to land.Apr 4 2024, 9:48 PM

Closed by commit rCOMM37b88717c320: [web] Use getMessageForException in shared worker connectHandler (authored by ashoat). · Explain WhyApr 5 2024, 6:32 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM37b88717c320: [web] Use getMessageForException in shared worker connectHandler.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

worker/

shared-worker.js

4 lines

Diff 38861

View Options

web/shared-worker/worker/shared-worker.js

[web] Use getMessageForException in shared worker connectHandlerClosedPublicActions