Page MenuHomePhabricator
Differential D11630

[lib/native] Delete FIDProvider
ClosedPublic
Actions

Authored by will on Apr 10 2024, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 10:20 PM
Unknown Object (File)
Mar 5 2025, 6:02 AM
Unknown Object (File)
Mar 5 2025, 6:02 AM
Unknown Object (File)
Mar 5 2025, 6:02 AM
Unknown Object (File)
Mar 5 2025, 6:02 AM
Unknown Object (File)
Feb 1 2025, 10:09 PM
Unknown Object (File)
Jan 26 2025, 5:04 AM
Unknown Object (File)
Jan 19 2025, 2:39 PM
View All 52 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM609c93977002: [lib/native] Delete FIDProvider
Summary

Once FIDProvider usages are replaced by synced metadata store, we can delete the FIDProvider

Depends on D11629

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
components/
native/
75 lines

Diff 39172

View Options

lib/components/fid-provider.react.js

Show All 40 Linesfunction DMOpsQueueHandler(): React.Node {
const threadInfos = useSelector(threadInfoSelector); const threadInfos = useSelector(threadInfoSelector);
const threadIDs = React.useMemo( const threadIDs = React.useMemo(
() => new Set(Object.keys(threadInfos)), () => new Set(Object.keys(threadInfos)),
[threadInfos], [threadInfos],
); );
const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set()); const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set());
const queuedOperations = useSelector( const queuedOperations = useSelector(
state => state.queuedDMOperations.operations, state => state.queuedDMOperations.threadQueue,
); );
const processDMOperation = useProcessDMOperation(); const processDMOperation = useProcessDMOperation();
React.useEffect(() => { React.useEffect(() => {
const prevThreadIDs = prevThreadIDsRef.current; const prevThreadIDs = prevThreadIDsRef.current;
prevThreadIDsRef.current = threadIDs; prevThreadIDsRef.current = threadIDs;
Show All 30 Lines
View Options

native/root.react.js

Show All 40 Linesfunction DMOpsQueueHandler(): React.Node {
const threadInfos = useSelector(threadInfoSelector); const threadInfos = useSelector(threadInfoSelector);
const threadIDs = React.useMemo( const threadIDs = React.useMemo(
() => new Set(Object.keys(threadInfos)), () => new Set(Object.keys(threadInfos)),
[threadInfos], [threadInfos],
); );
const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set()); const prevThreadIDsRef = React.useRef<$ReadOnlySet<string>>(new Set());
const queuedOperations = useSelector( const queuedOperations = useSelector(
state => state.queuedDMOperations.operations, state => state.queuedDMOperations.threadQueue,
); );
const processDMOperation = useProcessDMOperation(); const processDMOperation = useProcessDMOperation();
React.useEffect(() => { React.useEffect(() => {
const prevThreadIDs = prevThreadIDsRef.current; const prevThreadIDs = prevThreadIDsRef.current;
prevThreadIDsRef.current = threadIDs; prevThreadIDsRef.current = threadIDs;
Show All 30 Lines