Page MenuHomePhabricator
Differential D11626

[lib] have landing send `fid` as a string and not a number
ClosedPublic
Actions

Authored by will on Apr 10 2024, 11:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 9:30 AM
Unknown Object (File)
Sun, Nov 3, 10:07 AM
Unknown Object (File)
Oct 17 2024, 2:45 PM
Unknown Object (File)
Oct 17 2024, 2:44 PM
Unknown Object (File)
Oct 13 2024, 12:41 AM
Unknown Object (File)
Oct 13 2024, 12:41 AM
Unknown Object (File)
Oct 13 2024, 12:41 AM
Unknown Object (File)
Oct 13 2024, 12:41 AM
View All 58 Files
Subscribers
ashoat
tomek

Details

Reviewers
ginsu
atul
ashoat
Commits
rCOMM17bad29c6ff5: [lib] have landing send `fid` as a string and not a number
Summary

native expects a string but fid received is a number.

Context: https://linear.app/comm/issue/ENG-7679/type-mismatch-bug-in-farcaster-web-view-reactjs

Test Plan

flow check. Checked on native that receiving correct string fid after connecting my farcaster account

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Apr 10 2024, 11:19 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 10 2024, 11:19 PM
will added a child revision: D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.Apr 10 2024, 11:34 PM
Harbormaster completed remote builds in B28152: Diff 39026.Apr 10 2024, 11:35 PM
will requested review of this revision.Apr 10 2024, 11:35 PM
will updated this revision to Diff 39031.Apr 11 2024, 12:17 AM

toString on landing instead of after parse

will retitled this revision from [lib] convert `data.fid` which is a number to a string to [lib] have landing send `fid` as a string and not a number.Apr 11 2024, 12:19 AM
will edited the summary of this revision. (Show Details)
will edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B28157: Diff 39031.Apr 11 2024, 12:33 AM
ashoat accepted this revision.Apr 11 2024, 4:10 AM
This revision is now accepted and ready to land.Apr 11 2024, 4:10 AM
ginsu added a comment.Apr 11 2024, 8:41 AM

thanks for catching this @will. I thought I addressed this but looking at connect-farcaster.react.js now I can see I accidentally only toString() the farcaster auth url. Would you mind updating this diff to remove the toString() for the auth url? It's typed as a string already so doesn't make sense to toString() a string

ginsu accepted this revision.Apr 11 2024, 8:41 AM
will updated this revision to Diff 39059.Apr 11 2024, 8:57 AM
will edited the test plan for this revision. (Show Details)

remove toString() on url which is already a string

Harbormaster completed remote builds in B28172: Diff 39059.Apr 11 2024, 9:15 AM
Closed by commit rCOMM17bad29c6ff5: [lib] have landing send `fid` as a string and not a number (authored by will). · Explain WhyApr 11 2024, 10:25 AM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM17bad29c6ff5: [lib] have landing send `fid` as a string and not a number.

Revision Contents
Changeset List

PathSize
landing/
2 lines

Diff 39066

View Options

landing/connect-farcaster.react.js

Loading...