Paths

Table of Contentst

Differential D11626

[lib] have landing send `fid` as a string and not a number
ClosedPublic
Actions

Authored by will on Wed, Apr 10, 11:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 3:10 PM

	Unknown Object (File)
	Mon, Apr 22, 2:30 PM

	Unknown Object (File)
	Mon, Apr 22, 1:10 PM

	Unknown Object (File)
	Sun, Apr 21, 7:51 PM

	Unknown Object (File)
	Sun, Apr 21, 4:14 PM

	Unknown Object (File)
	Thu, Apr 18, 6:32 AM

	Unknown Object (File)
	Wed, Apr 17, 5:12 PM

	Unknown Object (File)
	Wed, Apr 17, 4:46 PM

View All 16 Files

Subscribers

Details

Reviewers

ginsu
atul
ashoat

Commits

rCOMM17bad29c6ff5: [lib] have landing send `fid` as a string and not a number

Summary

native expects a string but fid received is a number.

Context: https://linear.app/comm/issue/ENG-7679/type-mismatch-bug-in-farcaster-web-view-reactjs

Test Plan

flow check. Checked on native that receiving correct string fid after connecting my farcaster account

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Wed, Apr 10, 11:19 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Apr 10, 11:19 PM

will added a child revision: D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.Wed, Apr 10, 11:34 PM

Harbormaster completed remote builds in B28152: Diff 39026.Wed, Apr 10, 11:35 PM

will requested review of this revision.Wed, Apr 10, 11:35 PM

toString on landing instead of after parse

will retitled this revision from [lib] convert `data.fid` which is a number to a string to [lib] have landing send `fid` as a string and not a number.Thu, Apr 11, 12:19 AM

will edited the summary of this revision. (Show Details)

will edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B28157: Diff 39031.Thu, Apr 11, 12:33 AM

ashoat accepted this revision.Thu, Apr 11, 4:10 AM

This revision is now accepted and ready to land.Thu, Apr 11, 4:10 AM

thanks for catching this @will. I thought I addressed this but looking at connect-farcaster.react.js now I can see I accidentally only toString() the farcaster auth url. Would you mind updating this diff to remove the toString() for the auth url? It's typed as a string already so doesn't make sense to toString() a string

ginsu accepted this revision.Thu, Apr 11, 8:41 AM

remove toString() on url which is already a string

Harbormaster completed remote builds in B28172: Diff 39059.Thu, Apr 11, 9:15 AM

Closed by commit rCOMM17bad29c6ff5: [lib] have landing send `fid` as a string and not a number (authored by will). · Explain WhyThu, Apr 11, 10:25 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM17bad29c6ff5: [lib] have landing send `fid` as a string and not a number.

Revision Contents
Changeset List

Path

Size

landing/

connect-farcaster.react.js

2 lines

Diff 39066

landing/connect-farcaster.react.js

Loading...